Project

General

Profile

Bug #12650

Directive and Rule tree filter are very slow

Added by Alexis MOUSSET 7 months ago. Updated 6 months ago.

Status:
Released
Priority:
N/A
Category:
Web - UI & UX
Target version:
Severity:
User visibility:
Effort required:
Priority:
0

Description

On a server with hundreds of directifs, the directive tree filter is very slow (~5 seconds) and blocks the application when doing a search.

Seen on Firefox 52 ESR with Rudder 4.3.1.


Subtasks

Bug #12690: Rule tree filter is a bit slowReleasedNicolas CHARLES

Associated revisions

Revision eaebde7b (diff)
Added by Nicolas CHARLES 7 months ago

Fixes #12650: Directive tree filter is very slow

History

#1 Updated by Alexis MOUSSET 7 months ago

  • Description updated (diff)

#2 Updated by Vincent MEMBRÉ 7 months ago

  • Target version changed from 4.3.2 to 410

#3 Updated by Nicolas CHARLES 7 months ago

happens also on Edge

#4 Updated by Nicolas CHARLES 7 months ago

  • Target version changed from 410 to 4.1.13

Happens also on 4.1

#5 Updated by Nicolas CHARLES 7 months ago

Ok, it seems it is heavily manipulating the DOM, and at each character it does a change.
Searching for "test" in one JS call is pretty fast (at least, barely noticable)

$('#activeTechniquesTree').jstree('searchtag', 'test', [], false);

while simulating the typing with
$('#activeTechniquesTree').jstree('searchtag', 't', [], false);$('#activeTechniquesTree').jstree('searchtag', 'te', [], false);$('#activeTechniquesTree').jstree('searchtag', 'tes', [], false);$('#activeTechniquesTree').jstree('searchtag', 'test', [], false);

is pretty slow

as described in https://github.com/vakata/jstree/issues/1195 ( http://jsfiddle.net/no430s1f/2/ ) we should not immediately search, but rather have a small grace period for text change in the search box

#6 Updated by Nicolas CHARLES 7 months ago

  • Status changed from New to In progress
  • Assignee changed from Raphael GAUTHIER to Nicolas CHARLES

#7 Updated by Nicolas CHARLES 7 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1945

#8 Updated by Nicolas CHARLES 7 months ago

  • Assignee changed from Vincent MEMBRÉ to Raphael GAUTHIER

#9 Updated by Nicolas CHARLES 7 months ago

  • Assignee changed from Raphael GAUTHIER to Vincent MEMBRÉ

#10 Updated by Nicolas CHARLES 7 months ago

  • Assignee changed from Vincent MEMBRÉ to Raphael GAUTHIER

#11 Updated by Nicolas CHARLES 7 months ago

  • Related to Bug #12690: Rule tree filter is a bit slow added

#12 Updated by Normation Quality Assistant 7 months ago

  • Assignee changed from Raphael GAUTHIER to Nicolas CHARLES

#13 Updated by Nicolas CHARLES 7 months ago

  • Status changed from Pending technical review to Pending release

#14 Updated by Vincent MEMBRÉ 7 months ago

  • Target version changed from 4.1.13 to 4.1.12

#15 Updated by Benoît PECCATTE 6 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.12, 4.2.6 and 4.3.1 which were released today.

#16 Updated by Vincent MEMBRÉ 6 months ago

  • Subject changed from Directive tree filter is very slow to Directive and Rule tree filter are very slow

#17 Updated by Vincent MEMBRÉ 6 months ago

  • Related to deleted (Bug #12690: Rule tree filter is a bit slow)

Also available in: Atom PDF