Project

General

Profile

Actions
Copy link

Bug #12650

closed

Directive and Rule tree filter are very slow

Added by Alexis Mousset almost 6 years ago. Updated almost 6 years ago.

Status:
Released
Priority:
N/A
Assignee:
Nicolas CHARLES
Category:
Web - UI & UX
Target version:
4.1.12
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

On a server with hundreds of directifs, the directive tree filter is very slow (~5 seconds) and blocks the application when doing a search.

Seen on Firefox 52 ESR with Rudder 4.3.1.

Subtasks 1 (0 open — 1 closed)

Bug #12690: Rule tree filter is a bit slowReleasedNicolas CHARLESActions
Actions
Copy link
 #1

Updated by Alexis Mousset almost 6 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.3.2 to 410
Actions
Copy link
 #3

Updated by Nicolas CHARLES almost 6 years ago

happens also on Edge

Actions
Copy link
 #4

Updated by Nicolas CHARLES almost 6 years ago

  • Target version changed from 410 to 4.1.13

Happens also on 4.1

Actions
Copy link
 #5

Updated by Nicolas CHARLES almost 6 years ago

Ok, it seems it is heavily manipulating the DOM, and at each character it does a change.
Searching for "test" in one JS call is pretty fast (at least, barely noticable)

$('#activeTechniquesTree').jstree('searchtag', 'test', [], false);

while simulating the typing with
$('#activeTechniquesTree').jstree('searchtag', 't', [], false);$('#activeTechniquesTree').jstree('searchtag', 'te', [], false);$('#activeTechniquesTree').jstree('searchtag', 'tes', [], false);$('#activeTechniquesTree').jstree('searchtag', 'test', [], false);

is pretty slow

as described in https://github.com/vakata/jstree/issues/1195 ( http://jsfiddle.net/no430s1f/2/ ) we should not immediately search, but rather have a small grace period for text change in the search box

Actions
Copy link
 #6

Updated by Nicolas CHARLES almost 6 years ago

  • Status changed from New to In progress
  • Assignee changed from Raphael GAUTHIER to Nicolas CHARLES
Actions
Copy link
 #7

Updated by Nicolas CHARLES almost 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1945
Actions
Copy link
 #8

Updated by Nicolas CHARLES almost 6 years ago

  • Assignee changed from Vincent MEMBRÉ to Raphael GAUTHIER
Actions
Copy link
 #9

Updated by Nicolas CHARLES almost 6 years ago

  • Assignee changed from Raphael GAUTHIER to Vincent MEMBRÉ
Actions
Copy link
 #10

Updated by Nicolas CHARLES almost 6 years ago

  • Assignee changed from Vincent MEMBRÉ to Raphael GAUTHIER
Actions
Copy link
 #11

Updated by Nicolas CHARLES almost 6 years ago

  • Related to Bug #12690: Rule tree filter is a bit slow added
Actions
Copy link
 #12

Updated by Rudder Quality Assistant almost 6 years ago

  • Assignee changed from Raphael GAUTHIER to Nicolas CHARLES
Actions
Copy link
 #13

Updated by Nicolas CHARLES almost 6 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #14

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.13 to 4.1.12
Actions
Copy link
 #15

Updated by Benoît PECCATTE almost 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.12, 4.2.6 and 4.3.1 which were released today.

Actions
Copy link
 #16

Updated by Vincent MEMBRÉ almost 6 years ago

  • Subject changed from Directive tree filter is very slow to Directive and Rule tree filter are very slow
Actions
Copy link
 #17

Updated by Vincent MEMBRÉ almost 6 years ago

  • Related to deleted (Bug #12690: Rule tree filter is a bit slow)
Actions
Copy link

Also available in: Atom PDF