Project

General

Profile

Bug #13559

Check node, not group, for need of change request

Added by François ARMAND 3 months ago. Updated about 2 months ago.

Status:
Pending release
Priority:
N/A
Target version:
Severity:
User visibility:
Effort required:
Priority:
0

Description

For now, to check if a change request is needed for a given change, we look to groups.

But really, what we want to know, is if a node in one group must be checked, ie: it's a property of the node, not a property of the group, and the group is only a medium to set that property.

So, we need a resolver that for a node gives the list of groups applied to it, then for a rule to look for all set of group and their dependencies (from node), and then intersect that set with the list of supervised groups.

We also certainly need some explanation about why we will request change request, perhaps by logging example of node causing it.

The canonical use cases to deal with are:

- node1 and node2 in groupA, 
- node1 in groupB
- ruleA targets groupA, 
- groupB is supervised

==> a change to ruleA must trigger a validation request.

And:


- groupA is composed of groupB and other parameters, 
- node1 is in groupB, 
- ruleA targets groupA, 
- groupB is supervised

==> a change to ruleA must trigger a validation request. 

Associated revisions

Revision 4d9f4dfa (diff)
Added by François ARMAND 2 months ago

Fixes #13559: Check node, not group, for need of change request

History

#1 Updated by François ARMAND 2 months ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND

#2 Updated by François ARMAND 2 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder-plugins/pull/119

#3 Updated by François ARMAND 2 months ago

  • Status changed from Pending technical review to Pending release

#4 Updated by Vincent MEMBRÉ about 2 months ago

  • Project changed from 58 to Change validation
  • Target version changed from 445 to 5.0-1.0

Also available in: Atom PDF