Bug #13609
closed
Change request must not be saved when no validation is needed
Description
As found in #13567, we have an impedance mismatch between change request service and their repository.
When the workflow service is enable and the change does not trigger a change request, we have:
- A modification is made
- a change request is created by ChangeRequestService#createChangeRequestFromGlobalParameter (and other) and saved in the current enable workflow repository => the jdbc one,
- then we start the workflow, we see that no validation is needed, and we call NoWorkflow workflow, which try to delete the CR from its own repos (the inmemory one)
- and of course, that does not remove the CR from postgres.
If we use the same repos everywhere, we get a `IllegalArgumentException("This a developer error. Please contact rudder developer, saying that they call unemplemented deleteChangeRequest")` because we forbid deletion from JDBC (for auditing reason).
So, we need to NOT save the change request in the service, but in the first step of the workflow (if needed).
Updated by 
Updated by