Actions
Bug #14692
closedRudder agent check does not repair policies if they are broken
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:
Description
I volontarly corrupted policies and ran rudder agent check
Output is
# rudder agent check WARNING: No disable file detected and no agent executor process either. Restarting agent service...ok: stop service rudder-agent succeeded ok: start service rudder-agent succeeded Done /var/rudder/cfengine-community/inputs/promises.cf:18:4: error: syntax error iii ^ /var/rudder/cfengine-community/inputs/promises.cf:18:4: error: Expected 'bundle' or 'body' keyword, wrong input 'iii' iii ^ error: There are syntax errors in policy files ok: Rudder agent check ran without errors.
cf-promises does return exit code 1, but
# /var/rudder/cfengine-community/bin/cf-promises | grep error /var/rudder/cfengine-community/inputs/promises.cf:18:4: error: syntax error iii ^ /var/rudder/cfengine-community/inputs/promises.cf:18:4: error: Expected 'bundle' or 'body' keyword, wrong input 'iii' iii ^ error: There are syntax errors in policy files root@agent1:/home/vagrant# echo $? 1
errors are now in stderr rather than in stdout, so grep fails (but we could get exit code)
we could also use stderr in
# /var/rudder/cfengine-community/bin/cf-promises 2>&1 | grep error /var/rudder/cfengine-community/inputs/promises.cf:18:4: error: syntax error /var/rudder/cfengine-community/inputs/promises.cf:18:4: error: Expected 'bundle' or 'body' keyword, wrong input 'iii' error: There are syntax errors in policy files root@agent1:/home/vagrant# echo $? 0
Updated by Nicolas CHARLES over 5 years ago
- Related to Bug #14171: 'rudder-cf-execd' and 'rudder-cf-serverd' in status 'inactive (dead)' added
Updated by Nicolas CHARLES over 5 years ago
- Related to Bug #14061: Agent run errors are not outputed on stderr anymore added
Updated by Nicolas CHARLES over 5 years ago
- Status changed from New to In progress
- Assignee set to Nicolas CHARLES
Updated by Nicolas CHARLES over 5 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Nicolas CHARLES to Alexis Mousset
- Pull Request set to https://github.com/Normation/rudder-agent/pull/209
Updated by Nicolas CHARLES over 5 years ago
- Target version changed from 5.0.10 to 4.3.12
Updated by Nicolas CHARLES over 5 years ago
- Pull Request changed from https://github.com/Normation/rudder-agent/pull/209 to https://github.com/Normation/rudder-agent/pull/210
Updated by Rudder Quality Assistant over 5 years ago
- Assignee changed from Alexis Mousset to Nicolas CHARLES
Updated by Nicolas CHARLES over 5 years ago
- Status changed from Pending technical review to Pending release
Applied in changeset rudder-agent|b7772861670644bee3ab66d38d7b371cdd208d84.
Updated by Nicolas CHARLES over 5 years ago
- Related to Enhancement #14853: If policies are broken on the Rudder Server Root, they won't be repaired until a new policy generation added
Updated by Vincent MEMBRÉ over 5 years ago
- Subject changed from rudder agent check does not repair policies if they are broken to Rudder agent check does not repair policies if they are broken
Updated by Vincent MEMBRÉ over 5 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 4.3.12 and 5.0.10 which were released today.
Actions