Actions
Bug #15798
closedRationalize the handling of variables during policy generation
Status:
Released
Priority:
N/A
Assignee:
Category:
Performance and scalability
Target version:
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Reviewed
Fix check:
Checked
Regression:
Description
During a policy generation, we are moving around a lot of data, and some part ought to be rationalized (and even understood better)
Most notably, in prepareVariables, for each nodes and each policies, we are- getting all variables of the policy
- checking these variables, and constructing new variables based on them
- for each of these variable, we are constructing an STVariable
- getting the escaping method for this node
- escaping the variable value based on this escaping method
We could easily get only once the escaping method for the node (this is done 6194231 times on a generation with 4500 nodes, and 1.5 millions control point), and skip the middle man and create directly the STVariable from the checked Variable
Also, policy.mergeVars looks now quite dubious
Updated by Nicolas CHARLES about 5 years ago
- Status changed from New to In progress
- Assignee set to Nicolas CHARLES
Updated by Nicolas CHARLES about 5 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Nicolas CHARLES to François ARMAND
- Pull Request set to https://github.com/Normation/rudder/pull/2485
Updated by Vincent MEMBRÉ about 5 years ago
- Target version changed from 5.0.14 to 5.0.15
Updated by Nicolas CHARLES about 5 years ago
- Status changed from Pending technical review to Pending release
Applied in changeset rudder|f3ec4538aee8096060ee0db6202171ad2c1e3761.
Updated by Nicolas CHARLES about 5 years ago
Applied in changeset rudder|4754090ce95f550ca74f1395934039e2230943ab.
Updated by Alexis Mousset about 5 years ago
- Subject changed from Rationalize the handling of variable during a policy generation to Rationalize the handling of variables during policy generation
- Name check changed from To do to Reviewed
Updated by Nicolas CHARLES about 5 years ago
- Fix check changed from To do to Checked
Updated by Vincent MEMBRÉ about 5 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 5.0.15 which was released today.
Actions