Project

General

Profile

Actions
Copy link

Bug #15893

closed

Fix "Non exhaustive pattern match" warning

Added by François ARMAND about 5 years ago. Updated about 5 years ago.

Status:
Released
Priority:
N/A
Assignee:
Vincent MEMBRÉ
Category:
Architecture - Code maintenance
Target version:
5.0.14
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Reviewed
Fix check:
Checked
Regression:

Description

Warning:(120, 28) match may not be exhaustive.
It would fail on the following input: Left((x: Object forSome x not in (bootstrap.liftweb.checks.NcfTechniqueUpgradeError, bootstrap.liftweb.checks.NcfTechniqueUpgradeError.FlagFileError, bootstrap.liftweb.checks.NcfTechniqueUpgradeError.NcfApiAuthFailed)))
        authResponse       <- tryo ( authRequest.asString , "An error occurred while authentication to ncf API", NcfApiAuthFailed)

The problem is with the tryo definition, where catcher is defined on throwable and we only catch NcfApiAuthFailed here.

Actions
Copy link
 #1

Updated by François ARMAND about 5 years ago

  • Status changed from New to In progress
Actions
Copy link
 #2

Updated by François ARMAND about 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/2511
Actions
Copy link
 #3

Updated by François ARMAND about 5 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #4

Updated by Vincent MEMBRÉ about 5 years ago

  • Target version changed from 5.0.15 to 5.0.14
Actions
Copy link
 #5

Updated by François ARMAND about 5 years ago

  • Fix check changed from To do to Checked
Actions
Copy link
 #6

Updated by Alexis Mousset about 5 years ago

  • Subject changed from Non exhaustive pattern match to Fix "Non exhaustive pattern match" warning
  • Name check changed from To do to Reviewed
Actions
Copy link
 #7

Updated by Vincent MEMBRÉ about 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.14 which was released today.

Actions
Copy link

Also available in: Atom PDF