Project

General

Profile

Actions

Bug #16201

closed

Inefficient computing of compliance on home page

Added by Nicolas CHARLES over 1 year ago. Updated over 1 year ago.

Status:
Released
Priority:
N/A
Category:
Performance and scalability
Target version:
Severity:
User visibility:
Effort required:
Priority:
0

Description

On home page, we compute the compliance in two ways:
- Once by searching all rules non system, getting the compliance of these rules
- Once by getting the reports of all node, filtering out the reports linked to system directive, and getting the compliance out of these

The second one takes 15s in the filtering, and both approach looks really similar. Maybe we are really doing twice the same query, but it seems odd

We need to validate the result of both computation, to check that there are indeed similar or dissimilar, and then merge them if necessary

Also, getting the node last run is not batched, so we are doing one big query that is probably memory bound (and too intensive on the db)

Actions #1

Updated by Nicolas CHARLES over 1 year ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
Actions #2

Updated by Nicolas CHARLES over 1 year ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/2615
Actions #3

Updated by Nicolas CHARLES over 1 year ago

with this change, home page computation goes from 72s to 23s for 4500 nodes and 320 directives
memory usage should be lower too

Actions #4

Updated by Nicolas CHARLES over 1 year ago

  • Status changed from Pending technical review to Pending release
Actions #7

Updated by Vincent MEMBRÉ over 1 year ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.15 which was released today.

Actions

Also available in: Atom PDF