Bug #16201
closedInefficient computing of compliance on home page
Description
On home page, we compute the compliance in two ways:
- Once by searching all rules non system, getting the compliance of these rules
- Once by getting the reports of all node, filtering out the reports linked to system directive, and getting the compliance out of these
The second one takes 15s in the filtering, and both approach looks really similar. Maybe we are really doing twice the same query, but it seems odd
We need to validate the result of both computation, to check that there are indeed similar or dissimilar, and then merge them if necessary
Also, getting the node last run is not batched, so we are doing one big query that is probably memory bound (and too intensive on the db)
Updated by Nicolas CHARLES about 5 years ago
- Status changed from New to In progress
- Assignee set to Nicolas CHARLES
Updated by Nicolas CHARLES about 5 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Nicolas CHARLES to François ARMAND
- Pull Request set to https://github.com/Normation/rudder/pull/2615
Updated by Nicolas CHARLES about 5 years ago
with this change, home page computation goes from 72s to 23s for 4500 nodes and 320 directives
memory usage should be lower too
Updated by Nicolas CHARLES about 5 years ago
- Status changed from Pending technical review to Pending release
Applied in changeset rudder|6d33a8abb2d1ed254c00e2f15014ff645187e19f.
Updated by Alexis Mousset about 5 years ago
- Name check changed from To do to Reviewed
Updated by Nicolas CHARLES about 5 years ago
- Fix check changed from To do to Error - Fixed
Updated by Vincent MEMBRÉ about 5 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 5.0.15 which was released today.