Bug #17674: Global parameter "string" doesn't escape json - Rudder - Issue Tracker

Actions

Copy link

Bug #17674

closed

Global parameter "string" doesn't escape json

Added by François ARMAND almost 4 years ago. Updated almost 4 years ago.

Status:

Released

Priority:

N/A

Assignee:

Vincent MEMBRÉ

Category:

Web - Compliance & node report

Target version:

6.1.0~rc4

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

To do

Fix check:

To do

Regression:

Description

If you chose "string" for a global parameter and the value is json, it is not correctly escaped.

It does not seems blocking (just grave) since you can still print the json string, or add double quote to get a formatted json - but in that case, you also get the quote printed.

So, tu sum up, this is whant you get, and what we would like to have (in file enforce content):

global parameter name	global parameter value	in ldap	type in param	type in node	in file enforce content directive	printed in file	comment
p1	{ "foo":"bar" }	{"foo":"bar"}	string	json	${node.properties[p1]	{"foo":"bar"}	same as if the type was string but formating is lost, override will work like for json
p2	{"foo":"bar"}	{"foo":"bar"}	json	json	${node.properties[p2]	{"foo":"bar"}	as expected
p3	"{ "foo":"bar" }"	"\{\"foo\":\"bar\"\}"	string	string	${node.properties[p3]	"{ "foo":"bar" }"	as expected. Formatting kept, but " remains