Project

General

Profile

Actions

Bug #17698

closed

Bug #17641: Markdown descriptions in directives and groups are evaluated, resulting in Javascript execution

Tooltips in interface tree evaluate scripts

Added by Nicolas CHARLES almost 4 years ago. Updated 9 months ago.

Status:
Released
Priority:
N/A
Category:
Security
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:

Description

Trees in Directives and Active Technique pages display tooltips containing the description of the Technique.
However, this tooltip evaluates everything that is in the description, especially Javascript, that would get executed when hovering over a malicious Technique

For instance, creating a technique with decription <script>alert("bob");</script> and hovering over the technique in directives page or the active technique page shows the alert

Escaping the content of the tooltip fixes the issue


Related issues 1 (0 open1 closed)

Related to Rudder - Bug #14221: we can inject html & javascript in Rudder tablesReleasedFrançois ARMANDActions
Actions #1

Updated by Nicolas CHARLES almost 4 years ago

  • Target version changed from 6.0.7 to 5.0.18
Actions #2

Updated by Nicolas CHARLES almost 4 years ago

  • Description updated (diff)
Actions #3

Updated by Nicolas CHARLES almost 4 years ago

  • Related to Bug #14221: we can inject html & javascript in Rudder tables added
Actions #4

Updated by Nicolas CHARLES almost 4 years ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
Actions #5

Updated by Nicolas CHARLES almost 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/3073
Actions #6

Updated by Nicolas CHARLES almost 4 years ago

  • Status changed from Pending technical review to Pending release
Actions #7

Updated by Nicolas CHARLES almost 4 years ago

  • Subject changed from tooltip in jstree evaluate script to Tooltips in interface tree evaluate scripts
  • Description updated (diff)
Actions #8

Updated by Vincent MEMBRÉ almost 4 years ago

  • Status changed from Pending release to Released
Actions #9

Updated by Alexis Mousset 9 months ago

  • Private changed from Yes to No
Actions

Also available in: Atom PDF