Project

General

Profile

Actions

User story #18534

closed

User story #18314: Create Healthcheck webpage

User story #18357: Add check for free space

Skip non-standard moint FS for free-space check

Added by François ARMAND over 3 years ago. Updated over 3 years ago.

Status:
Released
Priority:
N/A
Category:
Web - Maintenance
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
To do
Fix check:
Checked
Regression:

Description

I got an error on healthcheck because an nfs mount point is reporting 0%. But we don't want an error on that:

Idea: only check space for /var/* path where the mount point is a standard one, ie prefilter the line and take only the one which starts with a "/":

cgroup on /sys/fs/cgroup/freezer type cgroup (rw,nosuid,nodev,noexec,relatime,seclabel,freezer)
cgroup on /sys/fs/cgroup/hugetlb type cgroup (rw,nosuid,nodev,noexec,relatime,seclabel,hugetlb)
cgroup on /sys/fs/cgroup/pids type cgroup (rw,nosuid,nodev,noexec,relatime,seclabel,pids)
configfs on /sys/kernel/config type configfs (rw,relatime)
/dev/mapper/cl-root on / type xfs (rw,relatime,seclabel,attr2,inode64,noquota)
selinuxfs on /sys/fs/selinux type selinuxfs (rw,relatime)
systemd-1 on /proc/sys/fs/binfmt_misc type autofs (rw,relatime,fd=40,pgrp=1,timeout=0,minproto=5,maxproto=5,direct,pipe_ino=17863)
hugetlbfs on /dev/hugepages type hugetlbfs (rw,relatime,seclabel,pagesize=2M)
mqueue on /dev/mqueue type mqueue (rw,relatime,seclabel)
debugfs on /sys/kernel/debug type debugfs (rw,relatime,seclabel)
/dev/sda1 on /boot type ext4 (rw,relatime,seclabel)
/dev/mapper/cl-home on /home type xfs (rw,relatime,seclabel,attr2,inode64,noquota)
sunrpc on /var/lib/nfs/rpc_pipefs type rpc_pipefs (rw,relatime)
vagrant on /vagrant type vboxsf (rw,nodev,relatime,iocharset=utf8,uid=1000,gid=1000)
tmpfs on /run/user/1000 type tmpfs (rw,nosuid,nodev,relatime,seclabel,size=84108k,mode=700,uid=1000,gid=1000)

Here: only consider /dev/mapper/cl-root, /dev/mapper/cl-home and /dev/sda1 (and so, /var should be checked against /dev/mapper/cf-root)


Files

clipboard-202011091542-qrugg.png (19.5 KB) clipboard-202011091542-qrugg.png François ARMAND, 2020-11-09 15:42

Related issues 1 (0 open1 closed)

Has duplicate Rudder - Bug #18522: heathcheck page complains about non existing mounting point sizeRejectedActions
Actions #1

Updated by Nicolas CHARLES over 3 years ago

  • Related to Bug #18522: heathcheck page complains about non existing mounting point size added
Actions #2

Updated by François ARMAND over 3 years ago

  • Related to deleted (Bug #18522: heathcheck page complains about non existing mounting point size)
Actions #3

Updated by François ARMAND over 3 years ago

  • Has duplicate Bug #18522: heathcheck page complains about non existing mounting point size added
Actions #4

Updated by François ARMAND over 3 years ago

  • Parent task deleted (#18357)
Actions #5

Updated by François ARMAND over 3 years ago

Actions #6

Updated by Elaad FURREEDAN over 3 years ago

  • Status changed from New to In progress
Actions #7

Updated by Elaad FURREEDAN over 3 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Elaad FURREEDAN to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/3351
Actions #8

Updated by Anonymous over 3 years ago

  • Status changed from Pending technical review to Pending release
Actions #9

Updated by François ARMAND over 3 years ago

  • Fix check changed from To do to Checked
Actions #10

Updated by Vincent MEMBRÉ over 3 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 6.2.0~rc1 which was released today.

Actions #11

Updated by Vincent MEMBRÉ over 3 years ago

  • Parent task set to #18357
Actions

Also available in: Atom PDF