Project

General

Profile

Actions
Copy link

Bug #19701

closed

Change-validation not building anymore in 7.0

Added by Elaad FURREEDAN over 2 years ago. Updated 9 months ago.

Status:
Released
Priority:
N/A
Assignee:
Nicolas CHARLES
Target version:
7.0-1.13
Pull Request:
https://github.com/Normation/rudder-p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:

Description

[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/ChangeRequestJdbcRepository.scala:107: error: value value is not a member of com.normation.rudder.domain.policies.DirectiveId
[ERROR]       , id.value
[ERROR]            ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/ChangeRequestJdbcRepository.scala:108: error: value value is not a member of com.normation.rudder.domain.policies.DirectiveId
[ERROR]       , s"could not fetch change request for directive with id ${id.value}" 
[ERROR]                                                                     ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/ValidationNeeded.scala:122: error: type mismatch;
[ERROR]  found   : net.liftweb.common.Box[Boolean]
[ERROR]  required: zio.ZIO[?,?,?]
[ERROR]       monitored <- monitoredTargets()
[ERROR]       monitored <- monitoredTargets()net.liftweb.common.Box[Boolean] <: zio.ZIO[?,?,?]?
[ERROR]                 ^
[INFO] false
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/ValidationNeeded.scala:121: error: type mismatch;
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/ValidationNeeded.scala:121: error: type mismatch;zio.ZIO[Any,com.normation.errors.RudderError,Nothing] <: net.liftweb.common.Box[?]?
[ERROR]  found   : zio.ZIO[Any,com.normation.errors.RudderError,Nothing]
[INFO] false
[INFO]  required: net.liftweb.common.Box[?]
[INFO]       nodeInfo  <- nodeInfoService.getAll()
[INFO]                 ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/ValidationNeeded.scala:171: error: type mismatch;
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/ValidationNeeded.scala:171: error: type mismatch;net.liftweb.common.Box[Boolean] <: zio.ZIO[?,?,?]?
[ERROR]  found   : net.liftweb.common.Box[Boolean]
[ERROR]  required: zio.ZIO[?,?,?]
[ERROR]  required: zio.ZIO[?,?,?]false
[ERROR]       monitored   <- monitoredTargets()
[ERROR]                   ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/ValidationNeeded.scala:170: error: type mismatch;
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/ValidationNeeded.scala:170: error: type mismatch;zio.ZIO[Any,com.normation.errors.RudderError,Nothing] <: net.liftweb.common.Box[?]?
[ERROR]  found   : zio.ZIO[Any,com.normation.errors.RudderError,Nothing]
[INFO] false
[INFO]  required: net.liftweb.common.Box[?]
[INFO]       allNodeInfo <- nodeInfoService.getAll()
[INFO]                   ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/ValidationNeeded.scala:199: error: type mismatch;
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/ValidationNeeded.scala:199: error: type mismatch;zio.ZIO[Any,com.normation.errors.RudderError,Boolean] <: net.liftweb.common.Box[?]?
[ERROR]  found   : zio.ZIO[Any,com.normation.errors.RudderError,Boolean]
[INFO] false
[INFO]  required: net.liftweb.common.Box[?]
[INFO]       nodeInfo  <- nodeInfoService.getAll()
[INFO]                 ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/ValidationNeeded.scala:203: error: value value is not a member of com.normation.rudder.domain.policies.DirectiveId
[ERROR]     ChangeValidationLogger.Metrics.debug(s"Check directive '${change.newDirective.name}' [${change.newDirective.id.value}] change requestion need for validation in ${System.currentTimeMillis() - start}ms")
[ERROR]                                                                                                                    ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:57: error: object parameters is not a member of package com.normation.rudder.domain
[ERROR] import com.normation.rudder.domain.parameters._
[ERROR]                                    ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:75: error: object GroupProperty is not a member of package com.normation.rudder.domain.nodes
[ERROR] import com.normation.rudder.domain.nodes.GroupProperty
[ERROR]        ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:750: error: type mismatch;
[ERROR]  found   : com.normation.rudder.domain.policies.DirectiveId
[ERROR]  required: com.normation.rudder.domain.policies.DirectiveUid
[ERROR]            case d : DeleteDirectiveDiff => <span>Delete Directive <a href={baseDirectiveLink(d.directive.id)} onclick="noBubble(event);">{d.directive.name}</a></span>
[ERROR]                                                                                                          ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:751: error: type mismatch;
[ERROR]  found   : com.normation.rudder.domain.policies.DirectiveId
[ERROR]  required: com.normation.rudder.domain.policies.DirectiveUid
[ERROR]            case m : ModifyToDirectiveDiff => <span>Modify Directive <a href={baseDirectiveLink(m.directive.id)} onclick="noBubble(event);">{m.directive.name}</a></span>
[ERROR]                                                                                                            ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:758: error: not found: type AddGlobalParameterDiff
[ERROR]            case a : AddGlobalParameterDiff => Text(s"Create Global Parameter ${a.parameter.name}")
[ERROR]                     ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:759: error: not found: type DeleteGlobalParameterDiff
[ERROR]            case d : DeleteGlobalParameterDiff => <span>Delete Global Parameter <a href={baseGlobalParameterLink(d.parameter.name)} onclick="noBubble(event);">{d.parameter.name}</a></span>
[ERROR]                     ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:760: error: not found: type ModifyToGlobalParameterDiff
[ERROR]            case m : ModifyToGlobalParameterDiff => <span>Modify Global Parameter <a href={baseGlobalParameterLink(m.parameter.name)} onclick="noBubble(event);">{m.parameter.name}</a></span>
[ERROR]                     ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:489: error: type mismatch;
[ERROR]  found   : com.normation.rudder.domain.policies.DirectiveId
[ERROR]  required: com.normation.rudder.domain.policies.DirectiveUid
[ERROR]     ( "#directiveID" #> createDirectiveLink(directive.id) &
[ERROR]                                                       ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:517: error: type mismatch;
[ERROR]  found   : com.normation.rudder.domain.policies.DirectiveId
[ERROR]  required: com.normation.rudder.domain.policies.DirectiveUid
[ERROR]     ( "#directiveID"      #> createDirectiveLink(directive.id) &
[ERROR]                                                            ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:458: error: not found: type GroupProperty
[ERROR]     def displayProperties(props: List[GroupProperty]) = {
[ERROR]                                       ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:670: error: not found: type ModifyGlobalParameterDiff
[ERROR]         diff          : ModifyGlobalParameterDiff
[ERROR]                         ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:671: error: not found: type GlobalParameter
[ERROR]       , param         : GlobalParameter
[ERROR]                         ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:662: error: not found: type GlobalParameter
[ERROR]   private[this] def displayGlobalParameter(param: GlobalParameter) = (
[ERROR]                                                   ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:559: error: value value is not a member of com.normation.rudder.domain.policies.DirectiveId
[ERROR]                   val msg = s"Could not display diff for ${directive.name} (${directive.id.value})" 
[ERROR]                                                                                            ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:635: error: not found: value ModifyToGlobalParameterDiff
[ERROR]             case ModifyToGlobalParameterDiff(param) =>
[ERROR]                  ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:141: error: type mismatch;
[ERROR]  found   : com.normation.rudder.domain.policies.DirectiveId
[ERROR]  required: com.normation.rudder.domain.policies.DirectiveUid
[ERROR]     def changes = changeRequest.directives(directiveId).changes
[ERROR]                                            ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:158: error: type mismatch;
[ERROR]  found   : com.normation.rudder.domain.policies.DirectiveUid
[ERROR]  required: com.normation.rudder.domain.policies.DirectiveId
[ERROR]     val children = changeRequest.directives.keys.map(directiveChild(_)).toList
[ERROR]                                                                     ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:212: error: not found: type AddGlobalParameterDiff
[ERROR]            case a :AddGlobalParameterDiff => a.parameter.name
[ERROR]                    ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:213: error: not found: type DeleteGlobalParameterDiff
[ERROR]            case d :DeleteGlobalParameterDiff => d.parameter.name
[ERROR]                    ^
[ERROR] /home/elaad/rudder-plugins/change-validation/src/main/scala/com/normation/plugins/changevalidation/snippet/ChangeRequestChangesForm.scala:214: error: not found: type ModifyToGlobalParameterDiff
[ERROR]            case modTo : ModifyToGlobalParameterDiff => modTo.parameter.name
[ERROR]                         ^
[ERROR] 28 errors
Actions
Copy link
 #1

Updated by Elaad FURREEDAN over 2 years ago

  • Target version set to 7.0-1.13
Actions
Copy link
 #2

Updated by Elaad FURREEDAN over 2 years ago

  • Status changed from New to In progress
Actions
Copy link
 #3

Updated by Elaad FURREEDAN over 2 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Elaad FURREEDAN to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder-plugins/pull/398
Actions
Copy link
 #4

Updated by Anonymous over 2 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ 9 months ago

  • Status changed from Pending release to Released
Actions
Copy link

Also available in: Atom PDF