Bug #20003
closed
Technique library may not be correctly reloaded when git commit happens when rudder is stopped
Description
We have a case where technique library may not be correctly reloaded if a git commit happened when rudder was stopped.
In that case, we can have the "reload technique lib", which update the current commit known by rudder, that happens before the callback that updates LDAP is registered.
We miss the callback, and then the lib seems to be up to date, but it is not.
Workaround: make a trivial change in all technques that were modified while rudder was stopped, commit, reload technique library.
Dev info: the problem is that `TechniqueAcceptationUpdater` is registered far away from the initialisation of the technique repository, and the git commit (provided by GitTechniqueVersionProvider) is already read and updated by that time. TechniqueRepository tells to noone "this is all the changes".
Updated by Vincent MEMBRÉ over 2 years ago
- Target version changed from 6.1.17 to 6.1.18
Updated by Vincent MEMBRÉ over 2 years ago
- Target version changed from 6.1.18 to 6.1.19
Updated by François ARMAND over 2 years ago
- Status changed from New to In progress
- Assignee set to François ARMAND
Updated by François ARMAND over 2 years ago
- Target version changed from 6.1.19 to 7.0.0~rc3
Updated by François ARMAND over 2 years ago
I'm not sure this bug is real.
Technique reload should not happen during boot before "force reload technique" boot check, which is quite far after callbacks have been initialized. Even with the automatic technique library reload (from CheckTechniqueLibrary) at minimum, it has one minute.
I think there was something different happening.
Updated by François ARMAND over 2 years ago
Work in progess here: https://github.com/fanf/rudder/commit/b87042ad97dcbfe15abc0a64ba6bf46dd7df155f
Updated by François ARMAND over 2 years ago
The wip above add a queue that registers boot change and replay them when callback are initialized.
In my tests, that queue is always empty.
Updated by François ARMAND over 2 years ago
- Status changed from In progress to Rejected
I think that the bug is not a real one. In #20462 we added a guard to delay policy generation after bootchecks are done, so it will run the "reload technique lib" check if needed. I'm closing it, and we will reopen one if we find what is the real problem (if there is still any).