Bug #22170
closed
A new group display no nodes while all linux are selected
Added by Alexis TARUSSIO almost 2 years ago.
Updated 10 months ago.
UX impact:
I hate Rudder for that
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Very Small
Description
Hello guys !
I just encounters a massive thing that make me hate both myself AND Rudder.
I create a rule wich deploy PHP / FPM/ etc... This works really fine, and to use it I must create a group and add it to the rule.
And by default when you create a group the criteria take all the node, which happened and I end up with php deploy on half on my infrastructure.
I think it's extremely dangerous when you industrialize massively your Architecture. User is responsible of what he's doing but Rudder should have safe guard.
The idea behind this issue, is to when you create a new group by default no node is add to the group.
best regards,
Alexis TARUSSIO
Files
- Category set to Web - UI & UX
- Target version set to 7.3.0~beta1
- UX impact set to I hate Rudder for that
- User visibility set to Infrequent - complex configurations | third party integrations
- Effort required set to Very Small
This makes a lot of sense.
- Target version changed from 7.3.0~beta1 to 7.3.0~rc1
In fact, we cannot have empty criteria from the UI
- Related to Bug #22400: Empty group criteria breaks UI for adding new criteria added
- Target version changed from 7.3.0~rc1 to 7.3.0
- Target version changed from 7.3.0 to 7.3.1
- Target version changed from 7.3.1 to 7.3.2
- Target version changed from 7.3.2 to 7.3.3
- Target version changed from 7.3.3 to 7.3.4
- Target version changed from 7.3.4 to 7.3.5
- Target version changed from 7.3.5 to 7.3.6
- Target version changed from 7.3.6 to 7.3.7
- Target version changed from 7.3.7 to 7.3.8
- Target version changed from 7.3.8 to 7.3.9
- Target version changed from 7.3.9 to 7.3.10
- Target version changed from 7.3.10 to 7.3.11
We don't have a simple way to change that apport from changing the default selector for the newly created group.
We could use something like a never validating regex, but I'm not sure it woon't be more surprising.
- Target version changed from 7.3.11 to 8.1.0~alpha1
We should wait for a major release to change that default behavior.
- Status changed from New to In progress
- Assignee set to François ARMAND
- Status changed from In progress to New
- Assignee deleted (
François ARMAND)
- Target version changed from 8.1.0~alpha1 to 7.3.11
OK, actually the main problem is that the group is displayed empty at creation until we click on "search" while it is not. So in the first dyn group update, it changes, which is extremely surprising.
- Tracker changed from Enhancement to Bug
- Subject changed from Group Criteria to null not to all node to A new group display no nodes while all linux are selected
- Priority set to 0
- Status changed from New to In progress
- Assignee set to François ARMAND
- Status changed from In progress to Pending technical review
- Assignee changed from François ARMAND to Vincent MEMBRÉ
- Pull Request set to https://github.com/Normation/rudder/pull/5255
- Status changed from Pending technical review to Pending release
It now correctly handled:
- when created, the group is saved with an empty selector:
- we really don't have any node for that group:
And then, we can go to group criteria, hit search then save directly to get all linux nodes like before, or actually specify criteria.
- Status changed from Pending release to Released
This bug has been fixed in Rudder 7.3.11 which was released today.
- Related to Bug #25820: On new groups, adding a prop leads to "No query defined for group" error added
- Related to Bug #25026: Groups can be created without any research criteria added
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by 
Updated by Anonymous