Bug #23000
closed
When changes messages are mandatory and saving a technique we have an error message about missing info but technique is saved
Description
I've set the "Make logs message mandatory" option in the Settings page, and when I want to update/save a technique, I get the following error
there are no prompt for a reason, and thus it's impossible to manage techniques
Happens in 7.3, may happen in earlier version
EDIT: the technique is correctly saved: the error message is not preventing that.
Files
Updated by François ARMAND over 1 year ago
- Priority changed from 128 to 152
- Regression changed from No to Yes
Updated by François ARMAND over 1 year ago
- Status changed from New to In progress
- Assignee set to François ARMAND
Updated by François ARMAND over 1 year ago
- Target version changed from 7.3.4 to 7.2.9
Updated by François ARMAND over 1 year ago
- Subject changed from When changes messages are mandatory, we can't do any technique change anymore to When changes messages are mandatory and saving a technique we have an error message about missing info but technique is saved
- Description updated (diff)
The problem is far worse from a dev point of view (and better from an user point of view): the technique is actually saved EVEN IF there is a message telling it is not.
Updated by François ARMAND over 1 year ago
So, it's a can of worm:
- we now see the error that has always been there, but before we just didn't take care of it
- the error was hidden because we always exec the change code before checking for message, because we eagerly eval the change in place of making a function of it for lazy eval (because Box and not ZIO)
- the problem should be the same for creating, deleting a technique
The correct solution is to have a change pop-up.
The workaround for now will be to provide a useless reason for technique changes.
Updated by François ARMAND over 1 year ago
- Status changed from In progress to Pending technical review
- Assignee changed from François ARMAND to Vincent MEMBRÉ
- Pull Request set to https://github.com/Normation/rudder/pull/4894
Updated by François ARMAND over 1 year ago
- Related to Bug #22895: When adding a directive to a rule we cannot add event log anymore added
Updated by Anonymous over 1 year ago
- Status changed from Pending technical review to Pending release
Applied in changeset rudder|afed2d783a0b8c880cd2dfb2e2405a84c212abd0.
Updated by Alexis Mousset over 1 year ago
- Fix check changed from To do to Checked
Updated by Vincent MEMBRÉ over 1 year ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 7.2.9 and 7.3.4 which were released today.