Bug #23606: Creating files with the file explorer fails when using invalid character - Rudder - Issue Tracker

Actions

Copy link

Bug #23606

closed

Creating files with the file explorer fails when using invalid character

Added by Nicolas CHARLES 7 months ago. Updated 5 months ago.

Status:

Released

Priority:

N/A

Assignee:

François ARMAND

Category:

Web - Config management

Target version:

8.0.4

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

To do

Fix check:

Checked

Regression:

Description

I tried to create a file named

<script>alert("true");</script>

with the file explorer in directive page, saved it, and nothing seemed to have happened
Webapp log say

2023-10-18 18:59:37+0000 ERROR com.normation.rudder.rest.internal.SharedFilesAPI - An error occurred while looking into directory <- An error occurred. Cause was: NoSuchFileException: /var/rudder/configuration-repository/shared-files/<script>alert("true");</script>

Files

clipboard-202310191655-mgnm5.png (15 KB) clipboard-202310191655-mgnm5.png

Alexis Mousset, 2023-10-19 16:55

Actions

Copy link

Updated by Alexis Mousset 7 months ago

There is no security impact. The FS refuses to create the file as its name contains a slash wich is the expected behavior.

The problem lies in error handling. It returns a 500 error with no indication to the user. We should add a failure notification in the interface.

Actions

Copy link

Updated by Alexis Mousset 7 months ago

File clipboard-202310191655-mgnm5.png clipboard-202310191655-mgnm5.png added

The 500 answer contains the error message so it is a pure UI problem

Actions

Copy link

Updated by Vincent MEMBRÉ 7 months ago

Target version changed from 8.0.1 to 8.0.2

Actions

Copy link

Updated by François ARMAND 6 months ago

Assignee set to Clark ANDRIANASOLO

Actions

Copy link

Updated by Clark ANDRIANASOLO 6 months ago

Status changed from New to In progress

Actions

Copy link

Updated by Clark ANDRIANASOLO 6 months ago · Edited

We should also prevent the user from doing such operation by disallowing an empty filename or any invalid character in the filename : '/' and '\0' (https://stackoverflow.com/a/1311070).

A notification should also be added in case of a server error...

Actions

Copy link

Updated by Clark ANDRIANASOLO 6 months ago · Edited

I got

2023-11-02 15:20:26+0100 ERROR com.normation.rudder.rest.internal.SharedFilesAPI - An error occurred while looking into directory <- An error occurred. Cause was: NoSuchFileException: /var/rudder/configuration-repository/workspace/.../resources/test.txt -> /var/rudder/configuration-repository/workspace/.../resources/test/coucou.txt
2023-11-02 15:25:16+0100 ERROR com.normation.rudder.rest.internal.SharedFilesAPI - An error occurred while looking into directory <- An error occurred. Cause was: NoSuchFileException: /var/rudder/configuration-repository/workspace/.../resources/testcouct.txt -> /var/rudder/configuration-repository/workspace/.../resources/testcouct''"a("é(/&
2023-11-02 15:26:16+0100 ERROR com.normation.rudder.rest.internal.SharedFilesAPI - An error occurred while looking into directory <- An error occurred. Cause was: FileAlreadyExistsException: /var/rudder/configuration-repository/workspace/.../resources

by trying those cases

Actions

Copy link