Project

General

Profile

Actions

Bug #25490

closed

Bug #25479: Users cleanup configuration is too strict on disabled users

User cleanup actions are logged every time even there is no change

Added by Clark ANDRIANASOLO 10 months ago. Updated 10 months ago.

Status:
Released
Priority:
N/A
Category:
API
Target version:
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
It bothers me each time
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Very Small
Priority:
73
Name check:
To do
Fix check:
Checked
Regression:
No

Description

I set up the clean cron to check every minute for users to cleanup : rudder.users.cleanup.cron=0 * * * * ?
But there is a warning log and many other info logs even if there are no changes at all :

2024-09-18 14:20:00+0200 WARN  application.authentication - Following users status changed to 'disabled' because they were inactive since 'PT1H': ''
2024-09-18 14:20:00+0200 INFO  application.authentication - Following users status changed from 'disabled' to 'deleted': ''
2024-09-18 14:20:00+0200 INFO  application.authentication - Users were purged from the database because they were configured to be purged PT720H after deletion. Users list is : ''
2024-09-18 14:20:00+0200 INFO  application.user - 0 user sessions older than 2024-08-19T14:20:00+02:00 were deleted
2024-09-18 14:20:00+0200 INFO  application.authentication - Log of user sessions older than 2024-08-19T14:20:00+02:00 were deleted
2024-09-18 14:20:00+0200 INFO  application.authentication - Cleaning user accounts and sessions performed in PT0.010S
There should be no logs when there are no changes in the user database, also there are several issues :
  • the sessions deletion log are duplicated, we should keep the first one which has the count of deleted sessions
  • when users have been changed, the separator spacing is wrong : 'user1' ,'user2' ,'user3'
Actions #1

Updated by Clark ANDRIANASOLO 10 months ago

  • Parent task set to #25479
Actions #2

Updated by Clark ANDRIANASOLO 10 months ago

  • Status changed from New to In progress
  • Assignee set to Clark ANDRIANASOLO
Actions #3

Updated by Clark ANDRIANASOLO 10 months ago

  • Description updated (diff)
Actions #4

Updated by Clark ANDRIANASOLO 10 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Clark ANDRIANASOLO to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/5886
Actions #5

Updated by Clark ANDRIANASOLO 10 months ago

  • Status changed from Pending technical review to Pending release
Actions #6

Updated by Clark ANDRIANASOLO 10 months ago

  • Fix check changed from To do to Checked
Actions #7

Updated by Vincent MEMBRÉ 10 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 8.1.7 which was released today.

Actions

Also available in: Atom PDF