Project

General

Profile

Actions
Copy link

Bug #25617

open

Discordance on node compliance between two tabs

Added by Lucas FRANCOIS 4 months ago. Updated 11 days ago.

Status:
New
Priority:
2
Assignee:
Raphael GAUTHIER
Category:
Web - UI & UX
Target version:
8.1.12
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
Trivial - no functional impact | cosmetic
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:
No

Description



When in nodes tab it shows 100% of compliance, but when clicking on the node it now shows 99%.

Files

Download all files
clipboard-202410071048-thrap.png (6.03 KB) clipboard-202410071048-thrap.png Lucas FRANCOIS, 2024-10-07 10:48
clipboard-202410071048-0uti6.png (39.9 KB) clipboard-202410071048-0uti6.png Lucas FRANCOIS, 2024-10-07 10:48
clipboard-202410101357-9jpqo.png (59.5 KB) clipboard-202410101357-9jpqo.png Nicolas CHARLES, 2024-10-10 13:57
Actions
Copy link
 #1

Updated by Lucas FRANCOIS 3 months ago

  • Priority changed from N/A to To review
Actions
Copy link
 #2

Updated by François ARMAND 3 months ago

  • Assignee set to Raphael GAUTHIER
  • Priority changed from To review to 2
Actions
Copy link
 #3

Updated by François ARMAND 3 months ago

  • Assignee changed from Raphael GAUTHIER to Vincent MEMBRÉ

It seems that the compliance score is not using the specified algo to compute compliance, which leads to rounding errors.

Actions
Copy link
 #4

Updated by Nicolas CHARLES 3 months ago

the compliance does not sum up to 100 on the nodes page

Actions
Copy link
 #5

Updated by Raphael GAUTHIER 3 months ago

  • Status changed from New to In progress
  • Assignee changed from Vincent MEMBRÉ to Raphael GAUTHIER
Actions
Copy link
 #6

Updated by Raphael GAUTHIER 3 months ago

  • Status changed from In progress to New
  • Assignee changed from Raphael GAUTHIER to Vincent MEMBRÉ
Actions
Copy link
 #7

Updated by Vincent MEMBRÉ 2 months ago

  • Target version changed from 8.1.8 to 8.1.9
Actions
Copy link
 #8

Updated by François ARMAND 2 months ago

On this one, we must understand why it was not caught by our unit tests and if it really use the algo that we have decided. @Vincent MEMBRÉ, can you:

- understand why we fall on that again,
- add the missing unit tests if some are missing (either in elm or scala),
- normalize the computation of percents so that we only have one way to do it (and same algo in scala, in elm)

Actions
Copy link
 #9

Updated by Vincent MEMBRÉ about 2 months ago

  • Target version changed from 8.1.9 to 8.1.10
Actions
Copy link
 #10

Updated by Vincent MEMBRÉ about 2 months ago

  • Target version changed from 8.1.10 to 8.1.11
Actions
Copy link
 #11

Updated by Vincent MEMBRÉ about 1 month ago

  • Status changed from New to In progress
Actions
Copy link
 #12

Updated by Vincent MEMBRÉ about 1 month ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Raphael GAUTHIER
  • Pull Request set to https://github.com/Normation/rudder/pull/6081
Actions
Copy link
 #13

Updated by Anonymous about 1 month ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #14

Updated by Vincent MEMBRÉ 20 days ago

  • Status changed from Pending release to New

Reverted because it removed the way to show compliance percent

Actions
Copy link
 #15

Updated by Vincent MEMBRÉ 11 days ago

  • Target version changed from 8.1.11 to 8.1.12
Actions
Copy link

Also available in: Atom PDF