User story #2604
closed
Be able to NOT historize inventories
Description
Today, each time we get an inventory through the inventory-web webapplication, an archive of the LDIF for that inventory is stored in the directory defined by the configuration property "history.inventories.rootdir" (by default, /var/rudder/inventories/historical)
That directory could growth a lot (a file is roughly 100k, so for 100 nodes and 3 months, that leads to 1Go of storage.
The main point is that not all these file are not used today in Rudder - they could be used to show previous inventory state of a node, even to diff between two inventory version, but for now, they are not.
Only the inventory file matching the time for the node acceptance is used to display it's inventory at that date (and we don't have a way, for now, to say "keep only the inventory file that will match the inventory for when the user is going to accept the node")
So, it could be handy to disable that historization in a property file (inventory-web.properties) and re-enable it when the logic in Rudder side is implemented.
Note that desactivating the histororization mean that the user will not be able to see the inventory of the acceptation time of the node.
Updated by François ARMAND over 12 years ago
- Target version changed from 47 to 2.4.0~beta1
Updated by François ARMAND over 12 years ago
- Tracker changed from Question to User story
- Subject changed from Shouldn't we be able to NOT historize inventories ? to Be able to NOT historize inventories
- Status changed from Discussion to In progress
- Assignee changed from Jonathan CLARKE to François ARMAND
That improvement is trivial to implement, so let do it.
Updated by François ARMAND over 12 years ago
- Status changed from In progress to Pending technical review
- % Done changed from 0 to 100
Applied in changeset f462208871e4d377c4c26832fadce214fa47e8d0.
Updated by François ARMAND over 12 years ago
- Project changed from Rudder to 20
- Category deleted (
26)
Updated by François ARMAND over 12 years ago
- Status changed from Pending technical review to In progress
- % Done changed from 100 to 70
We also need to store the ldif version when accepting a node so that we can see the history at acceptation time.
Updated by François ARMAND over 12 years ago
- Status changed from In progress to Pending technical review
- % Done changed from 70 to 100
Applied in changeset 36460cac362419c545204ee412295c7ae62503aa.
Updated by Nicolas CHARLES over 12 years ago
- Status changed from Pending technical review to 10
I guess this is valid, thank you Francois
Updated by Jonathan CLARKE about 12 years ago
I know this was released a long time ago, but I'm only just picking up on it now.
If we don't need these files, and they take up a lot of space, then I think the default should be not to write them. Is there any technical reason not to do this?
Updated by François ARMAND about 12 years ago
- Description updated (diff)
Actually, I found one: there are used to show the state of the inventory when the node was accepted. I'm updating it the top-description accordingly.
Updated by Jonathan CLARKE about 12 years ago
François ARMAND wrote:
Actually, I found one: there are used to show the state of the inventory when the node was accepted. I'm updating it the top-description accordingly.
OK, in that case, I agree that we shouldn't disable it. But if it is required, I'm not sure I see the point of being able to disable it... Ideally, we should be able to disable only the parts that are not useful. So I'm opening a new user story to do that: #3058.
Also, the comment in the configuration file does not clearly state that disabling this will break being able to see the inventory of a node at acceptation time, so I'm opening a bug for that too: #3059.
Aside from these points, I can but validate this.
Updated by Jonathan CLARKE about 12 years ago
- Status changed from 10 to Released
Jonathan CLARKE wrote:
Aside from these points, I can but validate this.
And, done.
Updated by Benoît PECCATTE almost 10 years ago
- Project changed from 20 to Rudder
- Category set to Web - Nodes & inventories