Project

General

Profile

Actions

Bug #26264

open

The refresh button from the nodes webpage change the list of nodes in the other tab

Added by Félix DALLIDET 2 months ago. Updated 21 days ago.

Status:
Pending release
Priority:
N/A
Category:
Web - UI & UX
Target version:
Severity:
UX impact:
I hate Rudder for that
User visibility:
First impressions of Rudder
Effort required:
Very Small
Priority:
0
Name check:
To do
Fix check:
To do
Regression:
No

Description

If I click on the "refresh" button on the nodes webpage, it remove all the nodes from the list and I have to reload the entire page to see them back


Files

2025-01-28_13-01.png (32.6 KB) 2025-01-28_13-01.png Félix DALLIDET, 2025-01-28 13:02
clipboard-202501311809-cjcad.png (110 KB) clipboard-202501311809-cjcad.png Clark ANDRIANASOLO, 2025-01-31 18:09
Screenshot from 2025-01-31 18-07-15.png (76.5 KB) Screenshot from 2025-01-31 18-07-15.png Clark ANDRIANASOLO, 2025-01-31 18:09

Related issues 2 (1 open1 closed)

Related to Rudder - User story #26055: Change rudder 8.3 main menuReleasedClark ANDRIANASOLOActions
Related to Rudder - Bug #26260: The "Edit columns" button in the nodes webpage is displayed three timesPending releaseRaphael GAUTHIERActions

Updated by Clark ANDRIANASOLO 2 months ago · Edited

There is a bug in the front-end side : it passes no arguments for nodeIds when fetching node details from the API

But when reloading, it passes some node ids, apparently excluding the root server :

It should always pass an empty list

Actions #2

Updated by Clark ANDRIANASOLO about 2 months ago

Changes have been made in #26055 with the new tab structure in the same page, but the state of the two different node tables seems to be linked : when changing search criteria in the Search tab, the table is refreshed, but when refreshing the main list of nodes in the List table, the criteria is the same.

It is due to a shared global variable nodeIds, which is shared by both tables. It will need to be isolated for each table.

Actions #3

Updated by Clark ANDRIANASOLO about 2 months ago

Actions #4

Updated by François ARMAND about 1 month ago

So, we checked and we can confirm that the problem is only on search, and in the case of top post, likely the last search was not returning any node.
So we need to scope nodeIds js variable to be linked to only one datatable.

By default, we should also NOT init the search table, since it's strange to have all nodes when you come to the page. And it's bad from a perf since ALL nodes are returned.

Actions #5

Updated by Raphael GAUTHIER about 1 month ago

  • Status changed from New to In progress
  • Assignee set to Raphael GAUTHIER
Actions #6

Updated by François ARMAND about 1 month ago

  • Subject changed from The refresh button from the Node webpage flushes all nodes to The refresh button from the nodes webpage change the list of nodes in the other tab
Actions #7

Updated by Clark ANDRIANASOLO about 1 month ago

  • Related to Bug #26260: The "Edit columns" button in the nodes webpage is displayed three times added
Actions #8

Updated by Clark ANDRIANASOLO about 1 month ago

  • Assignee changed from Raphael GAUTHIER to Clark ANDRIANASOLO
Actions #9

Updated by Clark ANDRIANASOLO about 1 month ago

  • Status changed from In progress to Pending technical review
  • Pull Request set to https://github.com/Normation/rudder/pull/6222
Actions #10

Updated by Clark ANDRIANASOLO about 1 month ago

  • Assignee changed from Clark ANDRIANASOLO to Raphael GAUTHIER
Actions #11

Updated by Vincent MEMBRÉ 28 days ago

  • Target version changed from 8.3.0~beta1 to 8.3.0~beta2
Actions #12

Updated by Clark ANDRIANASOLO 21 days ago

  • Status changed from Pending technical review to Pending release
Actions

Also available in: Atom PDF