Actions
Architecture #27278
open
Architecture #26903: Migrate change-validation snippets to Elm
Post-snippet migration fixes and cleanup in change-validation
Status:
Pending technical review
Priority:
N/A
Assignee:
Target version:
Fix check:
To do
Regression:
No
Description
This PR aims to finalise the migration of the
change-validation lift snippets that have been migrated to Elm this far, which includes:
- a modification in the
ChangeRequestDetailsElm app and in theWorkflowServiceAPI :findNextStatusshould return a list of possible next statuses rather than up to a single possible status - deleting the 4 lift snippets that have been migrated, i.e.
ChangeValidationSettings.scala,ChangeRequestEditForm.scala,ChangeRequestChangesForm.scala, andChangeRequestDetails.scala
Files
Updated by Clark ANDRIANASOLO 1 day ago
· Edited
- File Peek 2025-07-15 11-30.gif Peek 2025-07-15 11-30.gif added
- Status changed from In progress to New
Note : Some precision :
Here is what could be done :
findNextStatus could be kept into a single value, and the API implementation could just make a list out of possible states.Here is what could be done :
- The frontend needs to be able to accept a change request in
Pending validationwith eitherPending deploymentorDeployedas next status :
- if the rights are sufficient, the frontend should make corresponding API calls to either
/changeRequest/id/accept?status=pending deploymentor/changeRequest/id/accept?status=deployed - the frontend should receive the list of status from the API, so the frontend only NEEDS the list in the API JSON response in the
nextStatusfield
- The backend should then return a list : the API implementation uses the
findNextStatusto put the direct next status in thenextStatus, but it could then be used to recursively create a list from all states, within the API implementation
Updated by Véronique HAYAERT about 20 hours ago
- Status changed from New to Pending technical review
- Pull Request set to https://github.com/Normation/rudder-plugins/pull/871
Actions