Architecture #27278
open
Architecture #26903: Migrate change-validation snippets to Elm
Post-snippet migration fixes and cleanup in change-validation
Added by Véronique HAYAERT 1 day ago.
Updated about 21 hours ago.
Status:
Pending technical review
Description
This PR aims to finalise the migration of the
change-validation lift snippets that have been migrated to Elm this far, which includes:
- a modification in the
ChangeRequestDetails Elm app and in the WorkflowService API : findNextStatus should return a list of possible next statuses rather than up to a single possible status
- deleting the 4 lift snippets that have been migrated, i.e.
ChangeValidationSettings.scala , ChangeRequestEditForm.scala , ChangeRequestChangesForm.scala , and ChangeRequestDetails.scala
Files
- Status changed from New to In progress
Note : Some precision :
findNextStatus could be kept into a single value, and the API implementation could just make a list out of possible states.
Here is what could be done :
- The frontend needs to be able to accept a change request in
Pending validation with either Pending deployment or Deployed as next status :
- if the rights are sufficient, the frontend should make corresponding API calls to either
/changeRequest/id/accept?status=pending deployment or /changeRequest/id/accept?status=deployed
- the frontend should receive the list of status from the API, so the frontend only NEEDS the list in the API JSON response in the
nextStatus field
- The backend should then return a list : the API implementation uses the
findNextStatus to put the direct next status in the nextStatus, but it could then be used to recursively create a list from all states, within the API implementation
- Status changed from New to Pending technical review
- Pull Request set to https://github.com/Normation/rudder-plugins/pull/871
Also available in: Atom
PDF
Updated by 
Updated by