Project

General

Profile

Actions
Copy link

Bug #2763

closed

Remove "implicit numeric widening" warning

Added by François ARMAND over 12 years ago. Updated about 12 years ago.

Status:
Released
Priority:
3
Assignee:
François ARMAND
Category:
Architecture - Code maintenance
Target version:
2.4.0~beta3
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

When compiling Rudder, there is a lot of "implicit numeric widening" warnings that may signal logic errors.
We must correct them.

Actions
Copy link
 #1

Updated by François ARMAND over 12 years ago

  • Status changed from 2 to Pending technical review
  • % Done changed from 0 to 100
Actions
Copy link
 #2

Updated by Nicolas CHARLES over 12 years ago

This is probably correct, but I'm a bit confused by the toSize transformed to toSize.toLong in the tests... what would be their benefits ?

Actions
Copy link
 #3

Updated by Nicolas PERRON over 12 years ago

Nicolas CHARLES wrote:

This is probably correct, but I'm a bit confused by the toSize transformed to toSize.toLong in the tests... what would be their benefits ?

François, could we consider this as an positive technical review ?

Actions
Copy link
 #4

Updated by François ARMAND over 12 years ago

@Nicolas P: I think so.

@Nicolas C: the goal of the ticket is to remove "implicit numeric widening", i.e for example when an Int is passed to a method waiting for a Long. Hence, the "toLong". Its benefits is that we have less warning.

Actions
Copy link
 #5

Updated by Nicolas PERRON over 12 years ago

Ok, I better understand now. I pass this issue to 2.4.0~beta3 and we can close this ticket.

Actions
Copy link
 #6

Updated by Nicolas PERRON over 12 years ago

  • Target version changed from 2.4.0~beta4 to 2.4.0~beta3

François, can you close this issue, please ?

Actions
Copy link
 #8

Updated by Nicolas CHARLES about 12 years ago

  • Status changed from Pending technical review to Released

Ha, for some reason, the commit have been done twice

Actions
Copy link

Also available in: Atom PDF