Bug #2763
closed
Remove "implicit numeric widening" warning
Added by François ARMAND about 12 years ago.
Updated almost 12 years ago.
Category:
Architecture - Code maintenance
Description
When compiling Rudder, there is a lot of "implicit numeric widening" warnings that may signal logic errors.
We must correct them.
- Status changed from 2 to Pending technical review
- % Done changed from 0 to 100
This is probably correct, but I'm a bit confused by the toSize transformed to toSize.toLong in the tests... what would be their benefits ?
Nicolas CHARLES wrote:
This is probably correct, but I'm a bit confused by the toSize transformed to toSize.toLong in the tests... what would be their benefits ?
François, could we consider this as an positive technical review ?
@Nicolas P: I think so.
@Nicolas C: the goal of the ticket is to remove "implicit numeric widening", i.e for example when an Int is passed to a method waiting for a Long. Hence, the "toLong". Its benefits is that we have less warning.
Ok, I better understand now. I pass this issue to 2.4.0~beta3 and we can close this ticket.
- Target version changed from 2.4.0~beta4 to 2.4.0~beta3
François, can you close this issue, please ?
- Status changed from Pending technical review to Released
Ha, for some reason, the commit have been done twice
Also available in: Atom
PDF