Project

General

Profile

Actions

User story #2782

closed

Use a real diff viewing for Directive modification event log

Added by François ARMAND over 12 years ago. Updated about 12 years ago.

Status:
Released
Priority:
2
Assignee:
Jean VILVER
Category:
Web - UI & UX
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

In EventLog screen, when we see a Directive modification event, we are flooded by a lot of not really meaningfull XML.

A first solution is to display a diff of the before/after XML.

I see two solution:

1/ create a unified diff of the two XML, and display it with something like http://torisugari.hostei.com/development/UnifiedDiffToHTMLTable.html
(it's really easy to create diff in Java server-side, with for ex. http://code.google.com/p/java-diff-utils/)

2/ directly use a Javascript diff like https://github.com/kpdecker/jsdiff

The second one seems the easier.

In each case, we are making strong assomption about the structure of the XML (not two much different) witch should be OK if the XML document is correctly pretty printed.


Files


Related issues 1 (0 open1 closed)

Has duplicate Rudder - Bug #2851: Viewing Directive modification diff in the event logs is too uglyReleasedJean VILVER2012-08-27Actions
Actions #1

Updated by Jonathan CLARKE over 12 years ago

  • Assignee deleted (Jean VILVER)
  • Target version changed from 2.4.0~beta4 to 24
Actions #2

Updated by Jean VILVER over 12 years ago

  • Status changed from 2 to Pending technical review
  • % Done changed from 0 to 100
Actions #3

Updated by Jean VILVER over 12 years ago

The result is in the attached image.

Actions #4

Updated by Jonathan CLARKE over 12 years ago

  • Assignee set to Jean VILVER
  • Target version changed from 24 to 2.4.0~beta5
Actions #5

Updated by Jean VILVER over 12 years ago

The result :

Actions #6

Updated by François ARMAND over 12 years ago

  • Status changed from Pending technical review to 10

That seems ok.
Jon, I let you see with Jean for the look'n'feel you want for the result.

Actions #7

Updated by Jonathan CLARKE over 12 years ago

  • Status changed from 10 to Released

Looks good to me! Thanks Jean.

Actions #8

Updated by Nicolas CHARLES over 12 years ago

  • Status changed from Released to Discussion

Jean, you did not include the license file in this commit ( https://github.com/kpdecker/jsdiff/blob/master/LICENSE )

Could you add it please ?

Actions #9

Updated by Jean VILVER over 12 years ago

  • Status changed from Discussion to Pending technical review
Actions #10

Updated by Nicolas CHARLES over 12 years ago

  • Status changed from Pending technical review to 10

This looks valid, thank you Jean

Actions #11

Updated by Jonathan CLARKE about 12 years ago

  • Status changed from 10 to Released
Actions

Also available in: Atom PDF