User story #2930
closedImprove Groups view display
Added by Jean VILVER about 12 years ago. Updated almost 12 years ago.
Description
Pull request : https://github.com/Normation/rudder/pull/6
Jean VILVER wrote:
Jean VILVER wrote:
[...]
The Changes:
General changes:
- the subsection model applied in other views is applied here.In group hierarchy:
- The green note is now gray and has been move below the group hierarchy tree
- when we click on a category, the category stay selected in the tree.In Group details:
- Every html fieldsets has been remove
- The reason explanation message is below the input
- The reason explanation label is now "Reason message"In Category details:
- The inputs have the same size
- The typo in "Parent category: :" is fixed (colons appear twice)
- In root category, the note below the delete button have a different display
Files
Updated by Jean VILVER about 12 years ago
- File group_hierarchy_before.png group_hierarchy_before.png added
- File group_hierarchy_after.png group_hierarchy_after.png added
- File group_info_before.png group_info_before.png added
- File group_info_after.png group_info_after.png added
In the images attached some of the work done.
What do you guys think?
Updated by Jonathan CLARKE about 12 years ago
- Status changed from New to Discussion
Looks good from these screenshots, but I don't understand how they fit together. Can we see a screenshot of the whole page please?
Updated by Jean VILVER about 12 years ago
- File group_view_after.png group_view_after.png added
Jonathan CLARKE wrote:
Looks good from these screenshots, but I don't understand how they fit together. Can we see a screenshot of the whole page please?
Attached the image.
Updated by Jonathan CLARKE about 12 years ago
Right, I thought so: this change reworks the screen to have a list at the top, and details at the bottom. I don't think this is a good idea, as we frequently have very long lists of groups, so this would mean the groups details would be waaaaaay down at the bottom of the page.
Updated by Jean VILVER about 12 years ago
Jonathan CLARKE wrote:
Right, I thought so: this change reworks the screen to have a list at the top, and details at the bottom. I don't think this is a good idea, as we frequently have very long lists of groups, so this would mean the groups details would be waaaaaay down at the bottom of the page.
All right, I'll work when I can on a version with the two subsections side by side.
Updated by Jean VILVER about 12 years ago
- File group_category_form2_after.png group_category_form2_after.png added
- File group_details_form_before.png group_details_form_before.png added
- File group_details_form_after.png group_details_form_after.png added
- File group_category_form_before.png group_category_form_before.png added
- File group_category_form_after.png group_category_form_after.png added
- File group_category_form2_before.png group_category_form2_before.png added
Jean VILVER wrote:
[...]
All right, I'll work when I can on a version with the two subsections side by side.
Attached, images of a new version.
The Changes:
General changes:
- the subsection model applied in other views is applied here.
In group hierarchy:
- The green note is now gray and has been move below the group hierarchy tree
In Group details:
- Every html fieldsets has been remove
- The reason explanation message is below the input
- The reason explanation label is now "Reason message"
In Category details:
- The inputs have the same size
- The typo in "Parent category: :" is fixed (colons appear twice)
- In root category, the note below the delete button have a different display
Updated by Jean VILVER about 12 years ago
Jean VILVER wrote:
[...]
In group hierarchy:
- The green note is now gray and has been move below the group hierarchy tree
Plus :
- when we click on a category, the category stay selected in the tree.
The goal is to prevent the problem seen in group_category_form_before.png: where the previous selection (a group) feels related to the category form on the right.
Updated by Jean VILVER about 12 years ago
- Status changed from Discussion to Pending technical review
- Target version changed from 24 to 2.5.0~beta1
The source is on a pull request:
https://github.com/Normation/rudder/pull/6
Updated by François ARMAND almost 12 years ago
- Status changed from Pending technical review to 12
- Target version changed from 2.5.0~beta1 to 24
Pull request seems ok.
Updated by Jonathan CLARKE almost 12 years ago
- Target version changed from 24 to 2.5.0~beta1
Updated by Arthur ANGLADE almost 12 years ago
here is the pull request with merge conflicts fixed : https://github.com/Normation/rudder/pull/49
Updated by Arthur ANGLADE almost 12 years ago
- Assignee set to Nicolas CHARLES
- % Done changed from 0 to 100
Updated by Arthur ANGLADE almost 12 years ago
- Status changed from 12 to Pending release
Applied in changeset f2b3855ce5b237cf868dcadc6acdfc1b2f17fa16.
Updated by Nicolas CHARLES almost 12 years ago
Applied in changeset dba3c7ef4683fd61dc94351ea372f848af8a6609.
Updated by Matthieu CERDA almost 12 years ago
- Status changed from Pending release to Released