Bug #2933
closed
The use of "&&" prevent Rudder to generate promises if not escaped, then a test in the techniques is needed
Added by Nicolas PERRON about 12 years ago.
Updated over 9 years ago.
Description
We should check that no "&&" not escaped are in the rudder-techniques repository to avoid cases where promises can't be generated by Rudder.
In some cases, the use of "&&" without escapement is acceptable:
- In the initial promises as there is no use of StringTemplate
- StringTemplate could be using && to surround its variables which is require to not let whitespaces between && and variable.
A good test could be to check that no whitespace exist between "&&" and the variable into techniques folder.
The test should check that no "&" or "&&" exist surrounded by whitespace but not only. Some typo could lead to:
- "sometext\&&sometext", "sometext&\&sometext", " &\&sometext", "sometext&\& " or " &\&sometext"
- " \&sometext", "sometext& ", "sometext\&" " &sometext"
- "sometext&& " or " &&sometext"
- Status changed from New to Pending technical review
- % Done changed from 0 to 100
The commit associated handle the simplest cases but it should be sufficient.
- Status changed from Pending technical review to Discussion
Nicolas PERRON wrote:
The commit associated handle the simplest cases but it should be sufficient.
This looks OK but I don't understand why you have commented out the REPOSITORY_PATH definition. This is clearly not related to this bug.
- Status changed from Discussion to In progress
- % Done changed from 100 to 90
Jonathan CLARKE wrote:
Nicolas PERRON wrote:
The commit associated handle the simplest cases but it should be sufficient.
This looks OK but I don't understand why you have commented out the REPOSITORY_PATH definition. This is clearly not related to this bug.
You're right, It's a mistake or I've forgotten to remove this comment before to commit but it must be undone.
- Status changed from In progress to Pending technical review
- % Done changed from 90 to 100
- Status changed from Pending technical review to Released
- Project changed from Rudder to 34
- Category deleted (
11)
- Project changed from 34 to Rudder
- Category set to Packaging
- Related to Bug #5283: Unhelpful feedback with special string template characters added
Also available in: Atom
PDF
Updated by Nicolas PERRON 
Updated by Jonathan CLARKE 
Updated by 
Updated by