Bug #2934
closed
possible None.get in EventLogServiceImpl
Added by Vincent MEMBRÉ over 11 years ago.
Updated over 11 years ago.
Category:
Web - Maintenance
Description
in method getListOfModificationEvents, there is an Option.get
we should at least pu a default value with a getOrElse
What do you think of 0 as default value ?
repository.getEventLogByCriteria(Some("eventtype in (" eventList ") and id > " +lastSuccess.id.get ), None, Some("id DESC") )
- Status changed from New to Discussion
- Assignee set to Nicolas PERRON
It seems like Nicolas is able to answer this question
- Assignee changed from Nicolas PERRON to Nicolas CHARLES
- Status changed from Discussion to 8
- Assignee changed from Nicolas CHARLES to Vincent MEMBRÉ
I think that 0 is a sane default value since the minimum id is 1 (based on the postgresql SQL).
You can do the correction Vincent
- Status changed from 8 to Pending technical review
- % Done changed from 0 to 100
- Status changed from Pending technical review to Released
This is good. But Vincent, can you explain why two commits ? Is it a merge that didn't tell its name, or did you really commit on both 2.4 and master ????
That's a merge !! there was only one commit in that merge, so it was considered as a commit, not as a merge
Also available in: Atom
PDF
Updated by Arthur ANGLADE 
Updated by 
Updated by