Project

General

Profile

Actions
Copy link

Bug #3106

closed

On Rudder 2.4.1~rc1, the reports from the server are in "No Answer" about distributePolicy

Added by Nicolas PERRON almost 12 years ago. Updated almost 12 years ago.

Status:
Released
Priority:
2
Assignee:
Jonathan CLARKE
Category:
System techniques
Target version:
2.4.2
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

On Rudder 2.4.1~rc1 installed on a SLES 11 SP1, the reports from the server itself isn't totally successful since the reports from distributePolicy is in a "No Answer" state. Indeed, it seems that a report from "Propagate promises" is expected but missing.

Pull Request URL: https://github.com/Normation/rudder-techniques/pull/20

Actions
Copy link
 #1

Updated by Nicolas PERRON almost 12 years ago

The fix is simple: use body class if_else instead of cf2_if_else.

The reason is that we are expecting a success report for an action (copy some files) but if the action is not necessary, the class is not thrown as the body class cf2_if_else doesn't implement kept:

body classes cf2_if_else(yes,no)
# meant to match cf2 semantics
{
promise_repaired => { "$(yes)" };
repair_failed    => { "$(no)" };
repair_denied    => { "$(no)" };
repair_timeout   => { "$(no)" };
}


body classes if_else(yes,no)
{
promise_kept     => { "$(yes)" };
promise_repaired => { "$(yes)" };
repair_failed    => { "$(no)" };
repair_denied    => { "$(no)" };
repair_timeout   => { "$(no)" };
}
Actions
Copy link
 #2

Updated by Nicolas PERRON almost 12 years ago

  • Description updated (diff)
  • Status changed from New to Pending technical review
  • Assignee set to Nicolas CHARLES
Actions
Copy link
 #3

Updated by Nicolas CHARLES almost 12 years ago

  • Status changed from Pending technical review to Pending release

This is valid
However the commit had the wrong number and it's been noticed only after the merge ... 3016 instead of 3106

Actions
Copy link
 #4

Updated by Nicolas CHARLES almost 12 years ago

The commit is commit:99fb64fda13fc9d60cef217293cf967ef567f886

Actions
Copy link
 #5

Updated by Jonathan CLARKE almost 12 years ago

This has been changed in the Techniques, but not in the initial promises. Is there a reason for this? Shouldn't it be sync'd?

Actions
Copy link
 #6

Updated by Nicolas CHARLES almost 12 years ago

Jonathan CLARKE wrote:

This has been changed in the Techniques, but not in the initial promises. Is there a reason for this? Shouldn't it be sync'd?

That's a good question.
The first thing the server does is to generate its own promises, so I guess it doesn't have much impact
But for better consistency it should be sync'd

Actions
Copy link
 #7

Updated by Nicolas CHARLES almost 12 years ago

  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE

The pull lrequest for the initial promises is here :
https://github.com/Normation/rudder-techniques/pull/22
Could you review it Jon ?

Actions
Copy link
 #8

Updated by Jonathan CLARKE almost 12 years ago

Nicolas CHARLES wrote:

The pull lrequest for the initial promises is here :
https://github.com/Normation/rudder-techniques/pull/22
Could you review it Jon ?

Great, merged. Thanks.

Actions
Copy link
 #9

Updated by Nicolas PERRON almost 12 years ago

  • Status changed from Pending release to Released
Actions
Copy link

Also available in: Atom PDF