Rudder

Jonathan CLARKE wrote:

This sounds like a reasonable request, and would make profit of one of CFEngine's more powerful features in file editing.

What are the exact parameters you need to add to the existing Technique? I assume just "Insert this text after a line matching this regex"? Or something else. Let's discuss the spec here before attempting any implementation.

• Insert this text after a line matching this regex to be sure to add the configuration property in the right location
• Add as one entire block ? This could be usefull if an order is expected in the add of content.

Nicolas PERRON wrote:

Jonathan CLARKE wrote:

Nicolas PERRON wrote:

Jonathan CLARKE wrote:

[...]

• Add as one entire block ? This could be usefull if an order is expected in the add of content.

This sounds to me like a separate feature: you seem to be implying that lines are not inserted in order currently. If so, that's a bug and should be filed in a separate ticket. Or is that not the case? If so, please clarify.

I'm not sure of this but I will test it. It seems to me that if just one line of the block defined is missing, it will be added to the end of the file which will not respect the initial order.

In fact, If I define A Directive that the file /tmp/bug_3293.txt should contain this:

This is the line 1
This is the line 2
This is the line 3
This is the line 4
This is the line 5
This is the line 6
This is the line 7

If the file does not exist, all would be fine.

If the file contains:

#This is the starting comment
This is the line 2
#Some comments there
This is the line 4
This is the line 5
#Other comments appears
This is the line 7
#This is the ending comment

The result will be:

#This is the starting comment
This is the line 2
#Some comments there
This is the line 4
This is the line 5
#Other comments appears
This is the line 7
#This is the ending comment
This is the line 1
This is the line 3
This is the line 6

The result is that lines has been added in order but still are not conform to the block defined in the Directive.

I suppose This is not really a bug but a new feature. What's your opinion, Jon ?

I don't know how to deal with that issue:

• There is a "bug" in all versions of this Technique:
  

  bundle edit_line set_arbitrary_file_content(content, enforce)
  {
  classes:
      "preserve_file_content" expression => strcmp("true", "$(enforce)");
  
  insert_lines:
    preserve_file_content::
      "$(content)" 
          insert_type => "preserve_block";
  
    !preserve_file_content::
      "$(content)";
  }
  

If the file has to be enforced, it is considered has preserved and then if the content is a block content, it will be preserve. If the file is not enforced, it will be not considered as preserved and then the content will be process for each line....

The use of preserve block will lead to a non convergent promise which will lead itself to a file containing at each run more lines

• If I try to preserve the block content, like said above, the content will be added at each run. Then, a solution could be to remove each line before to add the content we want but this will lead to a non convergent promise and the reporting will always considered as "repaired" instead of "success".

With these informations, I don't know how to do the work. Any idea ?

I think for block edition, a template would be more adapted, but a template is unusable in this case. We are hitting the limits of what we can do here...

Maybe it would be a job to be done in another technique, a templating one ?

i'm taking over the ticket

Pr is there
https://github.com/Normation/rudder-techniques/pull/256

Applied in changeset commit:6761c7297a9dc424bfea8577e5bee681d68bf3c9.

New PR: https://github.com/Normation/rudder-techniques/pull/258

Applied in changeset commit:3b3fae6b9a7d7ce422cf156f03598e88a0259e57.

bunlde edit_line rudder_ensure_section_content has not been added in stdlib in last pull request, since this issue has not been release, I'm making another one to add it again it

Applied in changeset commit:eaa87aa59a3d45177c1ccbab3a152d3a12eb5463.

Since we will not make any more releases of 2.4 version, moving all those issues to 2.6

This bug has been fixed in Rudder 2.6.10 which was released today.
Check out:

• The release announcement: http://www.rudder-project.org/pipermail/rudder-announce/2014-January/000070.html
• The full ChangeLog: http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog26
• Download information: https://www.rudder-project.org/site/get-rudder/downloads/