Bug #3392
closed
Archive name is not descriptive
Added by Dennis Cabooter about 11 years ago. Updated almost 11 years ago.
Description
The name of the Global archive zip file is not very descriptive. I can't see which is the latest, so I have to rename them manually to include date and time in the name.
Updated by Nicolas CHARLES about 11 years ago
- Tracker changed from User story to Bug
- Category set to Web - Maintenance
- Status changed from New to 8
- Assignee set to Nicolas CHARLES
- Priority changed from N/A to 4
- Target version set to 2.4.5
Indeed, proper naming would make sense; we'll work on this
Updated by François ARMAND about 11 years ago
- Status changed from 8 to Discussion
What would be a good namin scheme for you ?
Something like:
rudder-conf-[group|directive|rule|all]-[YYYY-MM-DD-HH-MM of the commit used as source].zip
Do you care of the Git commit ID currently in the name, or is this something dispensable ? (it seems to be).
Updated by Dennis Cabooter about 11 years ago
It looks like a good idea. I don't think the git commit id needs to be in the archive name.
Updated by François ARMAND about 11 years ago
- Status changed from Discussion to In progress
- Assignee changed from Nicolas CHARLES to François ARMAND
OK, let's go for that, that seems good.
Updated by François ARMAND about 11 years ago
Resulting name are not very understandable (because of all the two digits sequence), so I think we should use ISO8601 real format for date/time.
That would leads to filename like:
rudder-conf-[group|directive|rule|all]-[YYYY-MM-DDThh:MM:ss of the commit used as source].zip
Do anybody know about a problem for that (especially, does ":" could lead to problemes on some OS ?)
Updated by François ARMAND about 11 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from François ARMAND to Nicolas CHARLES
PR here: https://github.com/Normation/rudder/pull/174
Before validating it, we would have to check that ":" is really OK in filenames.
Updated by Nicolas CHARLES about 11 years ago
: is invalid on Windows system ( http://stackoverflow.com/questions/1665724/colon-asterisk-as-a-filename-delimiter ), and can be a pain for scp ( http://www.mikkelsen.tv/simon/blog/index.php/2008/01/09/how-to-scp-a-file-name-with-a-colon/ )
Could you drop the - and the : altogether ?, to have YYYYMMDDhhmmss ?
Updated by François ARMAND about 11 years ago
YYYMMDDhhmmss is not really human friendly ( 20130417170414... that took me several second to parse it... And that looks like a timestamp at first sight). 2013-04-17T170414 is perhaps not too bad ? (at least, there is a clear separation between date and time, and it's a valid ISO date (well, not excatly due to the missing +2:00 or Z, but I don't thing we want that).
OK, so some variation:
- 20130417170414
- 20130417T170414
- 2013-0417T170414
- 2013-04-17T170414
The last one seems to be the most François-parsable, so the pull request is updated with it, but it can be change if I have a big standard deviation from other humans.
Updated by Nicolas CHARLES almost 11 years ago
- Status changed from Pending technical review to Pending release
This has been merged, thank you Francois
Updated by François ARMAND almost 11 years ago
- % Done changed from 0 to 100
Applied in changeset 47e2d592242ac5a5fef4971d111a518931e22302.
Updated by Nicolas CHARLES almost 11 years ago
Applied in changeset 464dc31d0144b7d9a8eabf381bebf9abf9ec36d4.
Updated by François ARMAND almost 11 years ago
Applied in changeset fd107347cfa1fca5adbce2324d17d1d64b199439.
Updated by François ARMAND almost 11 years ago
Applied in changeset 1e35ca678532f3611517265b3cdeb7a54b9ade10.
Updated by Nicolas PERRON almost 11 years ago
- Status changed from Pending release to Released