Bug #3433
closed
Missing node id should be ignored for variable resolution in deployment
Added by François ARMAND over 11 years ago.
Updated about 11 years ago.
Category:
Web - Config management
Description
We can use variable in directive, like ${rudder.node.id} and the like.
When we are looking-up a variable of type target (i.e: ${rudder.some_rule_id.target.id}, and that one of the target can not be resolve, it should not block the deployment.
Typically, in internal Directive commons, ${rudder.haspolicyserver-root.target.hostname} should be resolve for available nodes.
- Status changed from Discussion to Pending technical review
- Assignee changed from François ARMAND to Nicolas CHARLES
- Target version changed from 2.5.2 to 2.5.3
I am really not convinced by this change.
Indeed, if a value that is expected is not there, it's probably better to fail rather than continue and generate promises that can be invalid.
- Status changed from Pending technical review to Discussion
- Assignee changed from Nicolas CHARLES to François ARMAND
- Target version changed from 2.5.3 to 2.5.4
- Target version changed from 2.5.4 to 2.5.5
- Target version changed from 2.5.5 to 2.5.6
- Target version changed from 2.5.6 to 2.6.4
What is the state of this bug ? is the issue true today ?
- Target version changed from 2.6.4 to 2.6.5
- Target version changed from 2.6.5 to 2.6.6
- Assignee changed from François ARMAND to Nicolas CHARLES
Nic: could you post your comment on the pull request, then close it, then close that one as invalid? Thanks!
- Status changed from Discussion to Rejected
I'm rejecting this ticket; I can be convinced by having the generation of promises of invalid nodes skipped, but clearly node generating everything with the risk of invalid value
Also available in: Atom
PDF
Updated by 
Updated by Nicolas PERRON 
Updated by