Rudder

I can confirm that it used to work prior to the upgrade.

The issue is still there. However, de output on the node reports succes:

R: @@sudoParameters@@result_success@@ce690900-304d-492e-9b82-cdc3decdedda@@a588d0ed-aa10-418a-aa6d-3b687107d748@@137@@Install@@None@@2013-06-04 13:35:33+02:00##2500fd48-2905-42ba-bfdf-e5c170b9a176@#sudo already installed
 !! Method invoked repairs
 -> Executing '/usr/sbin/visudo -c -s -f /etc/sudoers.rudder' ... (no timeout)
Q: "...bin/visudo -c -": /etc/sudoers.rudder: parsed OK
I: Last 1 quoted lines were generated by promiser "/usr/sbin/visudo -c -s -f /etc/sudoers.rudder" 
 -> Completed execution of /usr/sbin/visudo -c -s -f /etc/sudoers.rudder
R: @@sudoParameters@@result_success@@ce690900-304d-492e-9b82-cdc3decdedda@@a588d0ed-aa10-418a-aa6d-3b687107d748@@137@@sudoersFile@@None@@2013-06-04 13:35:33+02:00##2500fd48-2905-42ba-bfdf-e5c170b9a176@#The sudoers file did not require any modification

Dennis Cabooter wrote:

The issue is still there. However, de output on the node reports succes:

[...]

Ok and are these success messages present on the technical logs of the node in the Rudder WebUI ?

In the webapp this are the only tech logs that have to do with sudo:

2013-06-04 14:41     result_success     Global sudo management     Global: User management     sudoersFile     -     The sudoers file did not require any modification
2013-06-04 14:41     result_success     Global sudo management     Global: User management     Install     -     sudo already installed

Cool :)

This bugs occurs because of a bug CFEngine 3.4.

classes in the following extract are not thrown, so there is no reporting done.

  insert_lines:
    replace_attempted_env_reset::
      "Defaults env_reset";

    check_sudo_parameters_sudo_add_line_vars_defined::
      "${lines[${index}]}" 
        classes => kept_if_else("line_${index}_kept", "line_${index}_added", "line_${index}_add_failed");

  delete_lines:

    all_lines_defined.force::

      ".*" 
        delete_select => sudo_select_nomatch("${all_lines}"),
        classes => if_repaired("line_deleted");

This was working in cfengine 3.2. and reporting is working in 2.5 and 2.4

Is it possible to fix it?

The real explanation about that bug is that the last line inserted is not sending kept_promises.

In the actual version if you insert several users as sudoers, only the last inserted is not reporting (not necesserly the last in the list, really the last inserted).

I found a workaround, in inserting a comment line after all users lines are inserting, and then deleting this line (and if that line is not erased, as its a commentary it has no consequences)

This will be implemented very soon

The bug is opened in CFEngine bug tracker https://cfengine.com/dev/issues/2943

I've submitted a pull request to fix this problem
https://github.com/cfengine/core/pull/769

My patch wasn't accepted by CFEngine, they created this change, on Master
https://github.com/cfengine/core/pull/793

I'll try to backport it, to include it in our cfengine

Ok, they changed their pull request ( https://github.com/cfengine/core/pull/805/files )
However, it won't be applied on the 3.4 branch :(

Applied in changeset commit:0e25d257166042f2e201f48360855a9c695d7bf1.

This bug has been fixed in Rudder 2.6.3, which was released today.
Check out:

• The release announcement: http://www.rudder-project.org/pipermail/rudder-announce/2013-July/000036.html
• The full ChangeLog: http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog26
• Download information: http://www.rudder-project.org/foswiki/Download/