Project

General

Profile

Actions

Bug #3660

closed

Change Request can't be validated if there is trailing spaces in the modified object

Added by Vincent MEMBRÉ over 11 years ago. Updated over 11 years ago.

Status:
Released
Priority:
1 (highest)
Category:
Web - Maintenance
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

When modifying a Directive/Rule/group, if there is trailling spaces at the end of any field, the change request cannot be validated.

This is because the initial state saved for the change request is saved as an xml in postgres, and postgres trims all string when saving them.

So there is a difference between the current state (with spaces) and and the initial state (without any spaces)

Here a small example with the a long description

Current state (saved in configurationr repository and LDAP :

<longDescription>blablabla
bliblibli
blublublu
   </longdescription>

initial state of change request (saved in postgres):

<longDescription>blablabla
bliblibli
blublublu</longdescription>

This mean a change here is not possible because long desciprions are not the same

Actions #1

Updated by Vincent MEMBRÉ over 11 years ago

  • Status changed from New to In progress

When comparing strings between two directives/groups/rules: always trim them, so there's no trailling spaces comparison

Actions #2

Updated by Vincent MEMBRÉ over 11 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/233
Actions #3

Updated by Vincent MEMBRÉ over 11 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #4

Updated by Anonymous over 11 years ago

Actions #5

Updated by Nicolas PERRON over 11 years ago

  • Subject changed from Change request can't be validated if there is trailling spaces to Change Request can't be validated if there is trailing spaces in the modified object
Actions #6

Updated by Nicolas PERRON over 11 years ago

  • Status changed from Pending release to Released
Actions #7

Updated by Nicolas PERRON over 11 years ago

This bug has been fixed in Rudder 2.6.3, which was released today.
Check out:

Actions

Also available in: Atom PDF