Bug #3758: Technique "OpenSSH Server" v3.0: it does not correctly edit ssh ports on systems other than RHEL/SLES - Rudder - Issue Tracker

Actions

Copy link

Bug #3758

closed

Technique "OpenSSH Server" v3.0: it does not correctly edit ssh ports on systems other than RHEL/SLES

Added by Vincent MEMBRÉ over 11 years ago. Updated over 9 years ago.

Status:

Released

Priority:

1 (highest)

Assignee:

Nicolas CHARLES

Category:

Techniques

Target version:

2.7.0

Pull Request:

https://github.com/Normation/rudder-t...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

When using latest ssh configuration technique (3.0), ports are not correctly configured.

variable {this.rudder_openssh_server_config_ports} is not expanded which leads to having ports value to {this.rudder_openssh_server_config_ports}

here is the variable definition :

      "rudder_openssh_server_config_ports" 
        slist => { "@{${params}[sshd_config_ports]}" };

and its application

    (debian|redhat|SuSE).rudder_openssh_server_ports_edit::
      "${${params}[sshd_config_file]}" 
        edit_line => rudder_openssh_server_port_configuration("@{this.rudder_openssh_server_config_ports}"),
        classes   => rudder_common_classes("${class_prefix}_ports"),
        comment   => "Edit the OpenSSH listening ports in the configuration file";

Actions

Copy link

Updated by Nicolas PERRON over 11 years ago

Target version changed from 2.7.0~beta1 to 2.7.0~rc1

Actions

Copy link

Updated by Nicolas PERRON over 11 years ago

Target version changed from 2.7.0~rc1 to 2.7.0

Actions

Copy link

Updated by Jonathan CLARKE over 11 years ago

I cannot reproduce this using Rudder 2.7, it works just fine.

Actions

Copy link

Updated by Jonathan CLARKE over 11 years ago

Assignee set to Vincent MEMBRÉ

Vincent, can you test again see if you reproduce this? I really can't.

Actions

Copy link

Updated by Jonathan CLARKE over 11 years ago

Subject changed from sshConfiguration 3.0 does not correctly edit ssh ports to sshConfiguration 3.0 does not correctly edit ssh ports on systems other than RHEL/SLES
Status changed from New to 8
Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE

OK, we figured it out, this doesn't happen on SLES/RHEL/CentOS systems, which is where I was testing.

This is due to a missing class expression:

    (SuSE|redhat)::
      "rudder_openssh_server_startup_init_name" 
        string => "/etc/init.d/sshd";
      "rudder_openssh_server_startup_init_activation_command" 
        string => "/sbin/chkconfig --del sshd \&\& /sbin/chkconfig --add sshd";

      # Copy the list of Ports in the local bundle
      # This is mandatory because we cannot use remote slist in CFEngine 3.2
      "rudder_openssh_server_config_ports" 
        slist => { "@{${params}[sshd_config_ports]}" };

This second block ("Copy the list of Ports in the local bundle") should be in class "any".

Actions

Copy link

Updated by Jonathan CLARKE over 11 years ago

Status changed from 8 to Pending technical review
Assignee changed from Jonathan CLARKE to Nicolas CHARLES
Pull Request set to https://github.com/Normation/rudder-techniques/pull/158

PR available: https://github.com/Normation/rudder-techniques/pull/158

Actions

Copy link

Updated by Jonathan CLARKE over 11 years ago

Status changed from Pending technical review to Pending release
% Done changed from 0 to 100

Applied in changeset commit:a384ba3aafca4ef7b357365e809317d49dd295bf.

Actions

Copy link

Updated by Nicolas CHARLES over 11 years ago

Applied in changeset commit:84df619b805593900bf6f7107099150572a3acc9.

Actions

Copy link

Updated by Nicolas PERRON over 11 years ago

Subject changed from sshConfiguration 3.0 does not correctly edit ssh ports on systems other than RHEL/SLES to Technique "OpenSSH Server" v3.0: it does not correctly edit ssh ports on systems other than RHEL/SLES

Actions

Copy link

#10