Bug #3781: The XML parser which check metadata.xml of the Techniques display a wrong error message when the XML is malformed (Talk about SECTION when it is due to INPUTS) - Rudder - Issue Tracker

Actions

Copy link

Bug #3781

closed

The XML parser which check metadata.xml of the Techniques display a wrong error message when the XML is malformed (Talk about SECTION when it is due to INPUTS)

Added by Nicolas PERRON over 11 years ago. Updated almost 10 years ago.

Status:

Released

Priority:

N/A

Assignee:

François ARMAND

Category:

Web - Config management

Target version:

2.4.8

Pull Request:

https://github.com/Normation/cf-clerk...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

The XML parser in cf-clerk does not always display the right error message when a metadata.xml is malformed. In my case, I had an useless tag </INPUTS> in the metadata.xml and the message error was:

11:35:47.586 [qtp760805843-117] ERROR com.normation.cfclerk.services.impl.GitTechniqueReader - Ignoring technique '/applications/[...]/2.0/metadata.xml' because the descriptor file is malformed. Error message was: Unexpected issue with the descriptor file /applications/[...]/2.0/metadata.xml: The element type "SECTION" must be terminated by the matching end-tag "</SECTION>".

Actions

Copy link

Updated by Nicolas PERRON over 11 years ago

Target version changed from 2.4.7 to 2.4.8

Actions

Copy link

Updated by Nicolas CHARLES over 11 years ago

I'm looking for a way to have proper error messages
Not sure i'll be able to

Actions

Copy link

Updated by Nicolas CHARLES over 11 years ago

I can't do much more than listing the line and column error line, for the error message comes from the internal XML parser
the new error message is

ERROR com.normation.cfclerk.services.impl.GitTechniqueReader - Ignoring technique '/applications/apacheNegociationSSL/1.1/metadata.xml' because the descriptor file is malformed. Error message was: Unexpected issue with the descriptor file /applications/apacheNegociationSSL/1.1/metadata.xml at line 59, column 7: The element type "SECTION" must be terminated by the matching end-tag "</SECTION>"

Actions

Copy link

Updated by Nicolas CHARLES over 11 years ago

Status changed from New to Pending technical review
Assignee changed from Nicolas CHARLES to François ARMAND
Pull Request set to https://github.com/Normation/cf-clerk/pull/22

Actions

Copy link

Updated by François ARMAND over 11 years ago

Adding these information are a really good idea! Thanks NicolasC for thinking to it :)

Actions

Copy link

Updated by Nicolas CHARLES over 11 years ago

Status changed from Pending technical review to Pending release
% Done changed from 0 to 100

Applied in changeset clerk:commit:5b0100755dd9984bbd547d9816d580ad09c3b2d3.

Actions

Copy link

Updated by Anonymous over 11 years ago

Applied in changeset clerk:commit:dbe7f93ffb0c67b09ddbbd4b2131da0aabefd436.

Actions

Copy link

Updated by Nicolas PERRON over 11 years ago

Subject changed from The XML parser display a wrong error message when the XML is malformed (Talk about SECTION when it is due to INPUTS) to The XML parser which check metadata.xml of the Techniques display a wrong error message when the XML is malformed (Talk about SECTION when it is due to INPUTS)

Actions

Copy link