Project

General

Profile

Actions

User story #4100

closed

User story #4079: When Rudder does not start due to an error in rudder-users.xml, the webapp will display an usable error log

Improve log when users xml is not valid

Added by Vincent MEMBRÉ about 11 years ago. Updated over 9 years ago.

Status:
Released
Priority:
1 (highest)
Category:
System integration
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

When rudder-users.xml is not valid, the webapp send a massive execption where real information is very hard to find.

We should improve it by logging an error message:

[2013-10-22 17:40:01] ERROR application - Rudder user xml: An error occured while parsing the users xml file, and you won't be able to connect to Rudder webapp until you correct it and restarted Rudder webapp.
[2013-10-22 17:40:01] ERROR application - Rudder user xml: xml file is not correct, error message is: Le type d'élément "user" doit se terminer par la balise de fin correspondante "</user>". (line 105, column 3)
Actions #1

Updated by Vincent MEMBRÉ about 11 years ago

  • Status changed from In progress to 10
  • Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE

Jon, what do you think of those log message ?

Rudder user xml: An error occured while parsing the users xml file, and you won't be able to connect to Rudder webapp until you correct it and restarted Rudder webapp.
Rudder user xml: xml file is not correct, error message is: Le type d'élément "user" doit se terminer par la balise de fin correspondante "</user>". (line 105, column 3)
Actions #2

Updated by Vincent MEMBRÉ about 11 years ago

  • Pull Request set to https://github.com/Normation/rudder/pull/356
Actions #3

Updated by Vincent MEMBRÉ about 11 years ago

  • Assignee changed from Jonathan CLARKE to François ARMAND

I changed the message and forced the Locale to be in english for this message.

Result is:

[2013-10-23 10:47:09] ERROR application - User definitions: An error occured while parsing /opt/rudder/etc/rudder-users.xml. Logging in to the Rudder web interface will not be possible until this is fixed and the application restarted.
[2013-10-23 10:47:09] ERROR application - User definitions: XML in file /opt/rudder/etc/rudder-users.xml is incorrect, error message is: The element type "user" must be terminated by the matching end-tag "</user>". (line 105, column 3)

Going to technical review (but can't change it :()

Pull request here: https://github.com/Normation/rudder/pull/356

Actions #4

Updated by François ARMAND about 11 years ago

  • Status changed from 10 to Pending technical review
Actions #5

Updated by François ARMAND about 11 years ago

  • Status changed from Pending technical review to In progress
  • Assignee changed from François ARMAND to Vincent MEMBRÉ

Remarks in the pr!

Actions #6

Updated by Vincent MEMBRÉ about 11 years ago

  • Status changed from In progress to 10
  • Assignee changed from Vincent MEMBRÉ to François ARMAND

Remarks adressed! going back to technical review.

Actions #7

Updated by Vincent MEMBRÉ about 11 years ago

  • Status changed from 10 to Pending release
  • % Done changed from 0 to 100
Actions #8

Updated by Anonymous about 11 years ago

Actions #9

Updated by Vincent MEMBRÉ about 11 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.8.0~rc1, which was released on Friday 25/10/2013.
Check out:

Actions #10

Updated by Benoît PECCATTE almost 10 years ago

  • Category changed from 39 to System integration
Actions #11

Updated by Benoît PECCATTE over 9 years ago

  • Tracker changed from Enhancement to User story
Actions

Also available in: Atom PDF