Project

General

Profile

Bug #4142

/etc/hosts gets messed up by sed commands

Added by Jonathan CLARKE over 6 years ago. Updated almost 5 years ago.

Status:
Released
Priority:
3
Category:
Vagrant
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

The change from commit:f3c6d83cbe5a7761d4be6d37533e09c6dc22f08c causes this to happen to my hosts files:

[vagrant@server ~]$ cat /etc/hosts
127.0.0.1    server.rudder.local.rudder.local.rudder.local.rudder.local.rudder.local.rudder.local server localhost localhost.localdomain localhost4 localhost4.localdomain4

The sed command ends up adding the ".rudder.local" suffix multiple times. It needs fixing.

Associated revisions

Revision 625a0441 (diff)
Added by Benoît PECCATTE about 5 years ago

Fixes #4142: /etc/hosts gets messed up by sed commands

Revision 7fefd1ab
Added by Jonathan CLARKE about 5 years ago

Merge pull request #7 from peckpeck/bug_4142/etc_hosts_gets_messed_up_by_sed_commands

Fixes #4142: /etc/hosts gets messed up by sed commands

History

#1

Updated by Vincent MEMBRÉ over 6 years ago

Since Vagrant 1.3.0 (https://github.com/mitchellh/vagrant/blob/v1.3.0/CHANGELOG.md#130-september-5-2013), provisionning script is run only at first boot of the VM.

then up the vm again does not call the provisionning script.

I don't think our provisioning script should be run after first boot, it would wipe datas from the vm (calling rudder-init.sh at the end), and if your goal was to make a fresh install, it would be better to wipe completely the VM.

However, I guess your right and the script should be less error prone when editing /etc/hosts

#2

Updated by Benoît PECCATTE about 5 years ago

  • Category set to Vagrant integration
  • Status changed from 8 to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
  • Target version set to 2.10.8
  • Pull Request set to https://github.com/Normation/rudder-vagrant/pull/7
#3

Updated by Benoît PECCATTE about 5 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:625a0441ddab881d9f7a7e138e78ea52e1e28501.

#4

Updated by Jonathan CLARKE about 5 years ago

Applied in changeset commit:7fefd1ab4eda3bf92817e319d2117dbeb60d46e8.

#5

Updated by Vincent MEMBRÉ about 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.10.8 and 2.11.5, which were released today (16/12/14)

#6

Updated by Benoît PECCATTE almost 5 years ago

  • Project changed from Rudder-Vagrant to Rudder tools
  • Category changed from Vagrant integration to Vagrant
#7

Updated by Benoît PECCATTE almost 5 years ago

  • Target version changed from 2.10.8 to 2.10

Also available in: Atom PDF