Bug #4142: /etc/hosts gets messed up by sed commands - Rudder tools - Issue Tracker

Actions

Copy link

Bug #4142

closed

/etc/hosts gets messed up by sed commands

Added by Jonathan CLARKE about 11 years ago. Updated over 9 years ago.

Status:

Released

Priority:

Assignee:

Jonathan CLARKE

Category:

Vagrant

Target version:

2.10

Pull Request:

https://github.com/Normation/rudder-v...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

The change from commit:f3c6d83cbe5a7761d4be6d37533e09c6dc22f08c causes this to happen to my hosts files:

[vagrant@server ~]$ cat /etc/hosts
127.0.0.1    server.rudder.local.rudder.local.rudder.local.rudder.local.rudder.local.rudder.local server localhost localhost.localdomain localhost4 localhost4.localdomain4

The sed command ends up adding the ".rudder.local" suffix multiple times. It needs fixing.

Actions

Copy link

Updated by Vincent MEMBRÉ about 11 years ago

Since Vagrant 1.3.0 (https://github.com/mitchellh/vagrant/blob/v1.3.0/CHANGELOG.md#130-september-5-2013), provisionning script is run only at first boot of the VM.

then up the vm again does not call the provisionning script.

I don't think our provisioning script should be run after first boot, it would wipe datas from the vm (calling rudder-init.sh at the end), and if your goal was to make a fresh install, it would be better to wipe completely the VM.

However, I guess your right and the script should be less error prone when editing /etc/hosts

Actions

Copy link