Project

General

Profile

Bug #4154

Add Fedora related dependencies to rudder-agent to allow it to build on this platform

Added by Christophe Nowicki over 6 years ago. Updated about 5 years ago.

Status:
Released
Priority:
1
Category:
Packaging
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

Hi,

I've build the rudder-agent package on Fedora 18 (an RPM based distro ;-) ) using:

https://github.com/Normation/rudder-packages/tree/master/rudder-agent

and I've found an missing dependency in the RPM package.

In the rudder-agent.spec file :

https://github.com/Normation/rudder-packages/blob/master/rudder-agent/SPECS/rudder-agent.spec

%if 0%{?rhel} && 0%{?rhel} >= 6
BuildRequires: tokyocabinet-devel
Requires: tokyocabinet
%define is_tokyocabinet_here true
%endif

Could you add the Fedora DistTag ?

%if 0%{?fedora} && 0%{?fedora} >= 7
BuildRequires: tokyocabinet-devel
Requires: tokyocabinet
%define is_tokyocabinet_here true
%endif

Thanks,

#1

Updated by François ARMAND over 6 years ago

Thanks for reporting.
Matthieu, I let you handle the next steps.

#2

Updated by Nicolas PERRON over 6 years ago

  • Target version set to 2.6.10

It affects at least Rudder 2.6

#3

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 2.6.10 to 2.6.11
#4

Updated by Matthieu CERDA over 6 years ago

  • Project changed from Rudder to packages
  • Status changed from New to In progress
  • Priority changed from N/A to 1

On it.

#5

Updated by Matthieu CERDA over 6 years ago

  • Subject changed from rudder-agent : libtokyocabinet.so.9: cannot open shared object on Fedora to The rudder-agent package is not compatible with Fedora systems
#6

Updated by Matthieu CERDA over 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/209

PR ready.

#7

Updated by Jonathan CLARKE over 6 years ago

  • Subject changed from The rudder-agent package is not compatible with Fedora systems to rudder-agent package does not declare TokyoCabinet dependency on Fedora systems
  • Status changed from Pending technical review to Discussion
  • Assignee changed from Jonathan CLARKE to Matthieu CERDA

I'm clarifying the title on this ticket, to make sure one ticket = one subject.

I've added comments in the PR, and I would kindly ask you to respect these basic principles - one fix per ticket, and no unrelated changes.

#8

Updated by Matthieu CERDA over 6 years ago

  • Status changed from Discussion to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE

updated

#9

Updated by Jonathan CLARKE over 6 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Jonathan CLARKE to Matthieu CERDA

I have just read through the whole spec file, and I now understand why you were introducing a "dmidecode" dependency (because there are RHEL dependencies for "dmidecode" and "kernel-utils"). I apologize for treating this hastily earlier.

Do you think you could clarify and change the ticket to be more general, for example about managing dependencies on the RPM for Fedora, and clarify why each dependency is needed or not needed? In particular, why add dmidecode but not kernel-utils?

Please clarify these items by comments in the spec file at the very least (for future reference). Thanks.

#10

Updated by Matthieu CERDA over 6 years ago

  • Subject changed from rudder-agent package does not declare TokyoCabinet dependency on Fedora systems to Add Fedora related dependencies to rudder-agent to allow it to build on this platform
  • Status changed from Discussion to In progress
  • % Done changed from 100 to 90
#11

Updated by Matthieu CERDA over 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
  • % Done changed from 90 to 100

PR updated :)

#12

Updated by Matthieu CERDA over 6 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:e2c22eeac4d633aa550cfad63485369ef90762af.

#13

Updated by Jonathan CLARKE over 6 years ago

Applied in changeset commit:450bd11af5f1144693139b0270fe752f4b0d94ff.

#14

Updated by Vincent MEMBRÉ over 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.6.11, which was released today.
Check out:

#15

Updated by Benoît PECCATTE about 5 years ago

  • Project changed from packages to Rudder
  • Category set to Packaging

Also available in: Atom PDF