Bug #4154: Add Fedora related dependencies to rudder-agent to allow it to build on this platform - Rudder - Issue Tracker

Actions

Copy link

Bug #4154

closed

Add Fedora related dependencies to rudder-agent to allow it to build on this platform

Added by Christophe Nowicki about 11 years ago. Updated almost 10 years ago.

Status:

Released

Priority:

1 (highest)

Assignee:

Jonathan CLARKE

Category:

Packaging

Target version:

2.6.11

Pull Request:

https://github.com/Normation/rudder-p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

Hi,

I've build the rudder-agent package on Fedora 18 (an RPM based distro ;-) ) using:

https://github.com/Normation/rudder-packages/tree/master/rudder-agent

and I've found an missing dependency in the RPM package.

In the rudder-agent.spec file :

https://github.com/Normation/rudder-packages/blob/master/rudder-agent/SPECS/rudder-agent.spec

%if 0%{?rhel} && 0%{?rhel} >= 6
BuildRequires: tokyocabinet-devel
Requires: tokyocabinet
%define is_tokyocabinet_here true
%endif

Could you add the Fedora DistTag ?

%if 0%{?fedora} && 0%{?fedora} >= 7
BuildRequires: tokyocabinet-devel
Requires: tokyocabinet
%define is_tokyocabinet_here true
%endif

Thanks,

Actions

Copy link

Updated by François ARMAND about 11 years ago

Thanks for reporting.
Matthieu, I let you handle the next steps.

Actions

Copy link

Updated by Nicolas PERRON about 11 years ago

Target version set to 2.6.10

It affects at least Rudder 2.6

Actions

Copy link

Updated by Vincent MEMBRÉ almost 11 years ago

Target version changed from 2.6.10 to 2.6.11

Actions

Copy link

Updated by Matthieu CERDA almost 11 years ago

Project changed from Rudder to 34
Status changed from New to In progress
Priority changed from N/A to 1 (highest)

On it.

Actions

Copy link

Updated by Matthieu CERDA almost 11 years ago

Subject changed from rudder-agent : libtokyocabinet.so.9: cannot open shared object on Fedora to The rudder-agent package is not compatible with Fedora systems

Actions

Copy link

Updated by Matthieu CERDA almost 11 years ago

Status changed from In progress to Pending technical review
Assignee changed from Matthieu CERDA to Jonathan CLARKE
% Done changed from 0 to 100
Pull Request set to https://github.com/Normation/rudder-packages/pull/209

PR ready.

Actions

Copy link

Updated by Jonathan CLARKE almost 11 years ago

Subject changed from The rudder-agent package is not compatible with Fedora systems to rudder-agent package does not declare TokyoCabinet dependency on Fedora systems
Status changed from Pending technical review to Discussion
Assignee changed from Jonathan CLARKE to Matthieu CERDA

I'm clarifying the title on this ticket, to make sure one ticket = one subject.

I've added comments in the PR, and I would kindly ask you to respect these basic principles - one fix per ticket, and no unrelated changes.

Actions

Copy link

Updated by Matthieu CERDA almost 11 years ago

Status changed from Discussion to Pending technical review
Assignee changed from Matthieu CERDA to Jonathan CLARKE

updated

Actions

Copy link

Updated by Jonathan CLARKE almost 11 years ago

Status changed from Pending technical review to Discussion
Assignee changed from Jonathan CLARKE to Matthieu CERDA

I have just read through the whole spec file, and I now understand why you were introducing a "dmidecode" dependency (because there are RHEL dependencies for "dmidecode" and "kernel-utils"). I apologize for treating this hastily earlier.

Do you think you could clarify and change the ticket to be more general, for example about managing dependencies on the RPM for Fedora, and clarify why each dependency is needed or not needed? In particular, why add dmidecode but not kernel-utils?

Please clarify these items by comments in the spec file at the very least (for future reference). Thanks.

Actions

Copy link

#10

Updated by Matthieu CERDA almost 11 years ago

Subject changed from rudder-agent package does not declare TokyoCabinet dependency on Fedora systems to Add Fedora related dependencies to rudder-agent to allow it to build on this platform
Status changed from Discussion to In progress
% Done changed from 100 to 90