Bug #4476: Newline characters may be missing from archived files in configuration repository - Rudder - Issue Tracker

Actions

Copy link

Bug #4476

closed

Newline characters may be missing from archived files in configuration repository

Added by Vincent MEMBRÉ about 10 years ago. Updated about 10 years ago.

Status:

Released

Priority:

Assignee:

Nicolas CHARLES

Category:

Web - Config management

Target version:

2.6.11

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

Some characters are not saved in archive file ...

This is due to scala xml pretty printer which remove those newline characters ...

if content of my directive is:

# Rudder manage this file 

173.143.102.0/24

what is acutally saved in my file is :

# Rudder manage this file 173.143.102.0/24

In Scala code it occurs on line 166 of GitArchiverUtils.scala:

FileUtils.writeStringToFile(fileName, xmlPrettyPrinter.format(elem), encoding)

Actions

Copy link

Updated by François ARMAND about 10 years ago

Subject changed from newline characters may not be saved in some archive file to The XML pretty printer used for configuration file archives sometimes does not write newline chars
Status changed from New to In progress
Assignee set to François ARMAND
Priority changed from N/A to 1

This is an authentic Scala XML bug and/or not-what-you-want-default, see: https://issues.scala-lang.org/browse/SI-4303

Actions

Copy link

Updated by François ARMAND about 10 years ago

Status changed from In progress to Pending technical review
Assignee changed from François ARMAND to Nicolas CHARLES
Pull Request set to https://github.com/Normation/rudder/pull/441

The pull request is here: https://github.com/Normation/rudder/pull/441

Actions

Copy link

Updated by François ARMAND about 10 years ago

Status changed from Pending technical review to Pending release
% Done changed from 0 to 100

Applied in changeset aa9b7c96cf56da13b4f05bc3c694c19b25912b38.

Actions

Copy link

Updated by Nicolas CHARLES about 10 years ago

Applied in changeset 2281589a5a6f25607aad7bdbe6fe62d137b21e18.

Actions

Copy link

Updated by Vincent MEMBRÉ about 10 years ago

Subject changed from The XML pretty printer used for configuration file archives sometimes does not write newline chars to Newline characters may be missing from archived files in configuration repository

Actions

Copy link