Project

General

Profile

Actions

Bug #4476

closed

Newline characters may be missing from archived files in configuration repository

Added by Vincent MEMBRÉ almost 9 years ago. Updated almost 9 years ago.

Status:
Released
Priority:
1
Category:
Web - Config management
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Regression:

Description

Some characters are not saved in archive file ...

This is due to scala xml pretty printer which remove those newline characters ...

if content of my directive is:

# Rudder manage this file 

173.143.102.0/24

what is acutally saved in my file is :

# Rudder manage this file 173.143.102.0/24

In Scala code it occurs on line 166 of GitArchiverUtils.scala:

FileUtils.writeStringToFile(fileName, xmlPrettyPrinter.format(elem), encoding)

Actions #1

Updated by François ARMAND almost 9 years ago

  • Subject changed from newline characters may not be saved in some archive file to The XML pretty printer used for configuration file archives sometimes does not write newline chars
  • Status changed from New to In progress
  • Assignee set to François ARMAND
  • Priority changed from N/A to 1

This is an authentic Scala XML bug and/or not-what-you-want-default, see: https://issues.scala-lang.org/browse/SI-4303

Actions #2

Updated by François ARMAND almost 9 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder/pull/441
Actions #3

Updated by François ARMAND almost 9 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #5

Updated by Vincent MEMBRÉ almost 9 years ago

  • Subject changed from The XML pretty printer used for configuration file archives sometimes does not write newline chars to Newline characters may be missing from archived files in configuration repository
Actions #6

Updated by Vincent MEMBRÉ almost 9 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.6.11, which was released today.
Check out:

Actions

Also available in: Atom PDF