Project

General

Profile

Actions

Bug #4805

closed

CheckGenericFileContent can have several "repaired" status on each of the different component, even is the end state is convergent

Added by Nicolas CHARLES over 10 years ago. Updated almost 10 years ago.

Status:
Released
Priority:
1 (highest)
Assignee:
Jonathan CLARKE
Category:
Techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

If we use checkGenericFileContent technique to remove a line, and add it back in a specific section, the line deletion and the section edition will both return repair, and will have an intermediate state with the file in a non consistent state. However, at the end of the application, the status is correct.

This is because we do one edition per component, rather than one edition for the file, with reporting per edition

This is a very impacting change, so it deserves a new minor version to fix the issue

Actions #1

Updated by Nicolas CHARLES over 10 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/355
Actions #2

Updated by Nicolas CHARLES over 10 years ago

  • Pull Request changed from https://github.com/Normation/rudder-techniques/pull/355 to https://github.com/Normation/rudder-techniques/pull/356

PR updated to https://github.com/Normation/rudder-techniques/pull/356
version is now 5.0 (with same code)

Actions #3

Updated by Nicolas CHARLES over 10 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:4ce21c3b9c0df2f11e38e3f4efe98b5817a8fbd5.

Actions #4

Updated by Vincent MEMBRÉ over 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.6.13 (announcement , changelog), 2.9.5 (announcement , changelog) and 2.10.1 (announcement , changelog), which were released today.

Actions #5

Updated by Benoît PECCATTE almost 10 years ago

  • Project changed from 24 to Rudder
  • Category changed from Techniques to Techniques
Actions

Also available in: Atom PDF