Project

General

Profile

Actions
Copy link

Bug #4908

closed

check-rudder-agent should source /etc/profile before starting

Added by Matthieu CERDA over 10 years ago. Updated almost 10 years ago.

Status:
Released
Priority:
3
Assignee:
Jonathan CLARKE
Category:
Packaging
Target version:
2.10.1
Pull Request:
https://github.com/Normation/rudder-p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

We usually source /etc/profile on our script to get environment variables.

check-rudder-agent does not, and we avoid problems by sometimes sourcing /etc/profile from the caller cron job.

This should be avoided, we should explicitely do it in check-rudder-agent :)

Actions
Copy link
 #1

Updated by Matthieu CERDA over 10 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Matthieu CERDA to Nicolas CHARLES
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/330

PR is ready.

Actions
Copy link
 #2

Updated by Nicolas CHARLES over 10 years ago

  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE

This should be linked to a ticket to remove the . /etc/profile in the techniques.
I'm not sure i can merge this, I let Jon decide on this one

Actions
Copy link
 #3

Updated by Matthieu CERDA over 10 years ago

I propose that we simply clean up the cron.d entry we currently use to remove all the legacy crap that is useless now that we have check-rudder-agent. It is here since enough revisions and tester enough to be trusted, let's clean things up a bit :)

However, this has to be done in 2.11

Actions
Copy link
 #4

Updated by Matthieu CERDA over 10 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:08a21e171ce2ce37d1547a8706d16700486ae30f.

Actions
Copy link
 #5

Updated by Jonathan CLARKE over 10 years ago

Applied in changeset commit:da82add6046a7335051b349dbacc0dfbd0d5aa48.

Actions
Copy link
 #6

Updated by Vincent MEMBRÉ over 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.10.1, which was released today.
Check out:

Actions
Copy link
 #7

Updated by Benoît PECCATTE almost 10 years ago

  • Project changed from 34 to Rudder
  • Category set to Packaging
Actions
Copy link

Also available in: Atom PDF