Project

General

Profile

Bug #5327

On 2.11 rudder-agent, "Repair" status is always defined, even if nothing is modified

Added by Nicolas CHARLES over 5 years ago. Updated about 5 years ago.

Status:
Released
Priority:
1
Category:
Techniques
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

CFengine 3.6.0 always reports Repaired status for field edit, if the value separator is in the value we set, even when it is not repairing
Bug on CFengine bugtracker is
https://dev.cfengine.com/issues/5271
https://dev.cfengine.com/issues/6467

and fix is https://github.com/cfengine/core/pull/1650/files


Related issues

Related to Rudder - User story #5942: Let user define the full gecos field in user management techniqueNewActions
#1

Updated by Nicolas CHARLES over 5 years ago

  • Project changed from Rudder to packages
#2

Updated by Nicolas CHARLES over 5 years ago

Ha. Actualy this patch is already applied in our tarball, so the pb must be elsewhere

#3

Updated by Nicolas CHARLES over 5 years ago

  • Status changed from In progress to 8

Tested on 3.6.1, this has not been fixed. I'm opening a new ticket on the CFengine bugtracker
https://dev.cfengine.com/issues/6467

#4

Updated by Nicolas CHARLES over 5 years ago

  • Description updated (diff)
  • Assignee deleted (Nicolas CHARLES)
#5

Updated by Nicolas PERRON over 5 years ago

  • Target version changed from 2.11.2 to 2.11.3
#6

Updated by Matthieu CERDA over 5 years ago

  • Target version changed from 2.11.3 to 2.11.4
#7

Updated by Nicolas CHARLES over 5 years ago

  • Project changed from packages to Techniques
  • Status changed from 8 to In progress
  • Assignee set to Nicolas CHARLES
  • Target version changed from 2.11.4 to 2.10.6

CFEngine didn't find a solution for it, yet
However, the issue here is that we use the set value with same separator that what is inside the value. It used to work, but now it isn't.
A fix is to use another body col (or equivalent) that doesn't use , as a separator.

I'm fixing it on 2.10 as user may have mixed 2.10-2.11 installation

#8

Updated by Nicolas CHARLES over 5 years ago

  • Category set to Techniques
  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/509
#9

Updated by Matthieu CERDA over 5 years ago

  • Target version changed from 2.10.6 to 2.10.7
#10

Updated by Nicolas CHARLES over 5 years ago

Note: there is also a tentativ fix by CFEngine of the whole issue
https://github.com/vohi/core/commit/77caac16aab82cb8b6239d59cf5e5eae8bb7e853

#11

Updated by Nicolas CHARLES over 5 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:967c9a6373c32c4d5789cb0b0cd5bad553b5cf86.

#12

Updated by Jonathan CLARKE over 5 years ago

Applied in changeset commit:eaecb58967198b506b8e1a014d1297acbcc9c6c4.

#13

Updated by Vincent MEMBRÉ over 5 years ago

  • Subject changed from CFEngine 3.6.0 always defines "repaired" for field_edit, even if it doesn't repair anything, causing a permanent Repair status in the reports to on 2.11 rudder-agent, "Repair" status is always defined, even if nothing is modified
#14

Updated by Vincent MEMBRÉ over 5 years ago

  • Subject changed from on 2.11 rudder-agent, "Repair" status is always defined, even if nothing is modified to On 2.11 rudder-agent, "Repair" status is always defined, even if nothing is modified
#15

Updated by Vincent MEMBRÉ over 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.10.7 and 2.11.4, which were released today.

#16

Updated by Benoît PECCATTE about 5 years ago

  • Project changed from Techniques to Rudder
  • Category changed from Techniques to Techniques

Also available in: Atom PDF