Project

General

Profile

Actions

Bug #5327

closed

On 2.11 rudder-agent, "Repair" status is always defined, even if nothing is modified

Bug #5327: On 2.11 rudder-agent, "Repair" status is always defined, even if nothing is modified

Added by Nicolas CHARLES almost 12 years ago. Updated over 11 years ago.

Status:
Released
Priority:
1 (highest)
Assignee:
Jonathan CLARKE
Category:
Techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

CFengine 3.6.0 always reports Repaired status for field edit, if the value separator is in the value we set, even when it is not repairing
Bug on CFengine bugtracker is
https://dev.cfengine.com/issues/5271
https://dev.cfengine.com/issues/6467

and fix is https://github.com/cfengine/core/pull/1650/files


Related issues 1 (1 open0 closed)

Related to Rudder - User story #5942: Let user define the full gecos field in user management techniqueNewActions

Updated by Nicolas CHARLES almost 12 years ago Actions #1

  • Project changed from Rudder to 34

Updated by Nicolas CHARLES almost 12 years ago Actions #2

Ha. Actualy this patch is already applied in our tarball, so the pb must be elsewhere

Updated by Nicolas CHARLES almost 12 years ago Actions #3

  • Status changed from In progress to 8

Tested on 3.6.1, this has not been fixed. I'm opening a new ticket on the CFengine bugtracker
https://dev.cfengine.com/issues/6467

Updated by Nicolas CHARLES almost 12 years ago Actions #4

  • Description updated (diff)
  • Assignee deleted (Nicolas CHARLES)

Updated by Nicolas PERRON almost 12 years ago Actions #5

  • Target version changed from 2.11.2 to 2.11.3

Updated by Matthieu CERDA almost 12 years ago Actions #6

  • Target version changed from 2.11.3 to 2.11.4

Updated by Nicolas CHARLES almost 12 years ago Actions #7

  • Project changed from 34 to 24
  • Status changed from 8 to In progress
  • Assignee set to Nicolas CHARLES
  • Target version changed from 2.11.4 to 2.10.6

CFEngine didn't find a solution for it, yet
However, the issue here is that we use the set value with same separator that what is inside the value. It used to work, but now it isn't.
A fix is to use another body col (or equivalent) that doesn't use , as a separator.

I'm fixing it on 2.10 as user may have mixed 2.10-2.11 installation

Updated by Nicolas CHARLES almost 12 years ago Actions #8

  • Category set to Techniques
  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/509

Updated by Matthieu CERDA almost 12 years ago Actions #9

  • Target version changed from 2.10.6 to 2.10.7

Updated by Nicolas CHARLES almost 12 years ago Actions #10

Note: there is also a tentativ fix by CFEngine of the whole issue
https://github.com/vohi/core/commit/77caac16aab82cb8b6239d59cf5e5eae8bb7e853

Updated by Nicolas CHARLES almost 12 years ago Actions #11

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:967c9a6373c32c4d5789cb0b0cd5bad553b5cf86.

Updated by Jonathan CLARKE almost 12 years ago Actions #12

Applied in changeset commit:eaecb58967198b506b8e1a014d1297acbcc9c6c4.

Updated by Vincent MEMBRÉ over 11 years ago Actions #13

  • Subject changed from CFEngine 3.6.0 always defines "repaired" for field_edit, even if it doesn't repair anything, causing a permanent Repair status in the reports to on 2.11 rudder-agent, "Repair" status is always defined, even if nothing is modified

Updated by Vincent MEMBRÉ over 11 years ago Actions #14

  • Subject changed from on 2.11 rudder-agent, "Repair" status is always defined, even if nothing is modified to On 2.11 rudder-agent, "Repair" status is always defined, even if nothing is modified

Updated by Vincent MEMBRÉ over 11 years ago Actions #15

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.10.7 and 2.11.4, which were released today.

Updated by Benoît PECCATTE over 11 years ago Actions #16

  • Project changed from 24 to Rudder
  • Category changed from Techniques to Techniques
Actions

Also available in: PDF Atom