Project

General

Profile

Actions

Bug #6518

closed

When we regenerate promises via 'Update' button, all promises are regenerated even if not needed

Added by Nicolas CHARLES almost 6 years ago. Updated almost 6 years ago.

Status:
Released
Priority:
2
Category:
Web - Config management
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

If I click on update now, Rudder will regenerate all promises, on all nodes.
Same, if I change a directive, rule or group, it will regenerate averything, even if there is no need for it

The problem is on the coparision between the cache and the generated hash: it checks also for the written date, that does not exists in the generated hash. So Rudder thinks all the nodes have changed

Actions #1

Updated by Nicolas CHARLES almost 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/849
Actions #2

Updated by Nicolas CHARLES almost 6 years ago

This also greatly improves the perfs of each deployment !

Actions #3

Updated by Nicolas CHARLES almost 6 years ago

  • Priority changed from N/A to 2
Actions #4

Updated by Nicolas CHARLES almost 6 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #6

Updated by Vincent MEMBRÉ almost 6 years ago

  • Subject changed from When we click on "update now", all promises are always regenerated - and same when changing any configuration parameter to When we regenerate promises via 'Update' button, all promises are regenerated even if not needed
Actions #7

Updated by Vincent MEMBRÉ almost 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.11 and 3.0.5 which were released today.

Actions

Also available in: Atom PDF