Project

General

Profile

Actions

Bug #6605

closed

Bug #6587: cfengine context is not updated properly when doing multiple indivudual package actions

Bug #6590: cfengine context is not updated properly when doing multiple indivudual package actions for 3.0

remove duplicated patch on cfengine

Added by Vincent MEMBRÉ over 9 years ago. Updated over 9 years ago.

Status:
Released
Priority:
1 (highest)
Category:
Packaging
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

#6587 introduced a patch for cfengine in 2.10 that was upmerged

#6590 introduced the same patch for 2.11.

So here we end up with two patches in 2.11 (and upper), that do the same things:

What should have been done:

First fix #6587, and merge it in 2.10
Upmerge it ( 2.10 -> 2.11) 
Fix #6590 by moving the patch file from #6587 and adapt it (git mv + edit ) 
Merge it in 2.11
Upmerge to 3.0 and beyond

Here we have to make a new issue to remove the wrong patch and that makes me sad :(

Alexis can you look at this please ? :)

a 'git rm' on the 2.10 patch should be enough :)

Actions #1

Updated by Benoît PECCATTE over 9 years ago

Oups, that's because we (I) forgot to manage the merge manually.

Actions #2

Updated by Vincent MEMBRÉ over 9 years ago

I think we should follow the procedure in the description in those cases ? don't you think?

Actions #3

Updated by Alexis Mousset over 9 years ago

  • Target version changed from 2.10.14 to 3.0.5
Actions #4

Updated by Alexis Mousset over 9 years ago

  • Status changed from New to In progress
Actions #5

Updated by Alexis Mousset over 9 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis Mousset to Vincent MEMBRÉ

PR https://github.com/Normation/rudder-packages/pull/661

The patches were for 2.11 and 3.0, so I removed the 2.11 patch from 3.0.

Actions #6

Updated by Vincent MEMBRÉ over 9 years ago

Haaaa you're right :D I meant 3.0

Actions #7

Updated by Alexis Mousset over 9 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #9

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 3.0.5 to 3.0.6
Actions #10

Updated by Vincent MEMBRÉ over 9 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.0.6 and 3.1.0~rc1 which were released on the 16th June 2015.

Actions

Also available in: Atom PDF