Project

General

Profile

Actions

Bug #6729

closed

After a partial promise generation, some nodes being a relay may have their promises stored in a non reachable location

Added by Nicolas CHARLES over 9 years ago. Updated over 9 years ago.

Status:
Released
Priority:
N/A
Category:
Web - Config management
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

If we do a partial promise regeneration, some node may have their new promises in the folder
/path/to/relay.new/path/to/node

rather than the good old /path/to/relay/path/to/node

More presillely, we have the following case to manage (node3 was removed in the generation):

1/ Relay and all nodes updated (historical defautl behaviour)

Generation gives:

relay/
  relay_promises
  share/{ node1, node2, node3 }
relay.new/
  relay_promises
  share/{ node1.new, node2.new }

We want ([U] means updated):

relay/
  relay_promises [U]
  share/{ node1 [U], node2 [U] }

2/ Relay promises not updated, some children updated:

Generation gives:

relay/
  relay_promises
  share/{ node1, node2, node3 }
relay.new/
  share/{ node1.new }

We want:

relay/
  relay_promises 
  share/{ node1 [U], node2 }

3/ Relay promises updated, some children updated:

Generation gives:

relay/
  relay_promises
  share/{ node1, node2, node3 }
relay.new/
  relay_promises
  share/{ node1.new }

We want:

relay/
  relay_promises [U]
  share/{ node1 [U], node2 }

We see that all the naive scheme of moving or copying can't be used, and that some set union and intersection of nodes modified or not modified must be done.


Subtasks 1 (0 open1 closed)

Bug #6914: Delete the folder with .new after promise generationReleasedFrançois ARMAND2015-07-01Actions

Related issues 1 (0 open1 closed)

Related to Rudder - Bug #7056: A test is not compiling on branch 2.11 since #6729 was mergedReleasedFrançois ARMAND2015-07-30Actions
Actions #1

Updated by François ARMAND over 9 years ago

  • Description updated (diff)
Actions #2

Updated by Nicolas CHARLES over 9 years ago

  • Status changed from New to Pending technical review
  • Assignee set to Vincent MEMBRÉ
  • Priority changed from N/A to 1 (highest)
  • Pull Request set to https://github.com/Normation/rudder/pull/883
Actions #3

Updated by Nicolas CHARLES over 9 years ago

  • Assignee changed from Vincent MEMBRÉ to François ARMAND
Actions #4

Updated by Nicolas CHARLES over 9 years ago

  • Status changed from Pending technical review to Pending release
Actions #6

Updated by Vincent MEMBRÉ over 9 years ago

This bug has been fixed in Rudder 2.10.15, 2.11.12, 3.0.7 and 3.1.0 which were released today.

Actions #7

Updated by Vincent MEMBRÉ over 9 years ago

  • Status changed from Pending release to Released
Actions #8

Updated by Vincent MEMBRÉ over 9 years ago

  • Related to Bug #7056: A test is not compiling on branch 2.11 since #6729 was merged added
Actions

Also available in: Atom PDF