Project

General

Profile

Actions

Bug #7020

closed

Copy ncf only if it is updated

Added by Nicolas CHARLES over 8 years ago. Updated over 8 years ago.

Status:
Released
Priority:
1
Category:
Performance and scalability
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

When we copy ncf on the nodes, we use a very naive method of checking every files, which uses network ressources and CPU

The solution to be used is to make at every run a hash of ncf, and compare the hash of ncf with what we have on the node. If they differ, then we copy the promise
The risk there is that promise were regenerated, but hash not yet computed, so in this case, we'll copy ncf if promises has been updated

Note: the relay will always check for update of ncf, to prevent delays that may arise between hash update and real update


Related issues 2 (0 open2 closed)

Related to Rudder - Bug #5459: Tools directory is not always correctly updated on nodesReleasedJonathan CLARKE2014-09-01Actions
Related to Rudder - Bug #7473: ncf copy is always repaired on server due to an non-convergent hash functionReleasedBenoît PECCATTE2015-11-25Actions
Actions #1

Updated by Nicolas CHARLES over 8 years ago

  • Related to Bug #5459: Tools directory is not always correctly updated on nodes added
Actions #2

Updated by Nicolas CHARLES over 8 years ago

ok, this mecanisms won't work, as we don't do two step copy for ncf (we always copy from the source)
The solution to be used is to make at every run a hash of ncf, and compare the hash of ncf with what we have on the node. If they differ, then we copy the promise
The risk there is that promise were regenerated, but hash not yet computed, so in this case, we'll copy ncf if promises has been update (this is also true for relay)

Actions #3

Updated by Nicolas CHARLES over 8 years ago

  • Description updated (diff)
  • Status changed from New to In progress
Actions #4

Updated by Nicolas CHARLES over 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/726
Actions #5

Updated by Nicolas CHARLES over 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #7

Updated by François ARMAND over 8 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.1.1 which was released today.

Actions #8

Updated by Jonathan CLARKE over 8 years ago

  • Related to Bug #7473: ncf copy is always repaired on server due to an non-convergent hash function added
Actions

Also available in: Atom PDF