Bug #7020
closedCopy ncf only if it is updated
Description
When we copy ncf on the nodes, we use a very naive method of checking every files, which uses network ressources and CPU
The solution to be used is to make at every run a hash of ncf, and compare the hash of ncf with what we have on the node. If they differ, then we copy the promise
The risk there is that promise were regenerated, but hash not yet computed, so in this case, we'll copy ncf if promises has been updated
Note: the relay will always check for update of ncf, to prevent delays that may arise between hash update and real update
Updated by Nicolas CHARLES over 9 years ago
- Related to Bug #5459: Tools directory is not always correctly updated on nodes added
Updated by Nicolas CHARLES over 9 years ago
ok, this mecanisms won't work, as we don't do two step copy for ncf (we always copy from the source)
The solution to be used is to make at every run a hash of ncf, and compare the hash of ncf with what we have on the node. If they differ, then we copy the promise
The risk there is that promise were regenerated, but hash not yet computed, so in this case, we'll copy ncf if promises has been update (this is also true for relay)
Updated by Nicolas CHARLES over 9 years ago
- Description updated (diff)
- Status changed from New to In progress
Updated by Nicolas CHARLES over 9 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Nicolas CHARLES to Benoît PECCATTE
- Pull Request set to https://github.com/Normation/rudder-techniques/pull/726
Updated by Nicolas CHARLES over 9 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset rudder-techniques|aba239425af84a84008de168286d76ffa62a66c2.
Updated by Benoît PECCATTE over 9 years ago
Applied in changeset rudder-techniques|1b7d893642404b2f284b8e3b5745991b92968894.
Updated by François ARMAND over 9 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 3.1.1 which was released today.
- Announcement 3.1
- Changelog 3.1
- Download information: https://www.rudder-project.org/site/get-rudder/downloads/
Updated by Jonathan CLARKE about 9 years ago
- Related to Bug #7473: ncf copy is always repaired on server due to an non-convergent hash function added