Project

General

Profile

Actions
Copy link

Bug #7622

closed

Technique files contains UTF-8 chars (especially spaces)

Added by François ARMAND almost 9 years ago. Updated over 7 years ago.

Status:
Released
Priority:
4
Assignee:
Benoît PECCATTE
Category:
Techniques
Target version:
3.1.20
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

There is several techniques files containing UTF-8 chars, especially an UTF-8 space.

AFAIK, these chars are only in comments, but I only looked in system techniques.

The problem with a change to remove them will be in merge where it will be hard to know what is the correct space to get.

For information, the joined file is a list of such chars in system techniques.

Files

utf8_spaces.patch (10.4 KB) utf8_spaces.patch François ARMAND, 2015-12-16 14:51
Actions
Copy link
 #1

Updated by Jonathan CLARKE almost 9 years ago

  • Assignee set to François ARMAND

I understand the observation, but I don't understand the problem - you have filed this as a bug, so could you please explain the negative impact or perceived risk?

Actions
Copy link
 #2

Updated by Benoît PECCATTE over 8 years ago

  • Target version set to 2.11.21
Actions
Copy link
 #3

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.21 to 2.11.22
Actions
Copy link
 #4

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.22 to 2.11.23
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.23 to 2.11.24
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 2.11.24 to 308
Actions
Copy link
 #7

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 308 to 3.1.14
Actions
Copy link
 #8

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.1.14 to 3.1.15
Actions
Copy link
 #9

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.1.15 to 3.1.16
Actions
Copy link
 #10

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.1.16 to 3.1.17
Actions
Copy link
 #11

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 3.1.17 to 3.1.18
Actions
Copy link
 #12

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 3.1.18 to 3.1.19
Actions
Copy link
 #13

Updated by François ARMAND over 7 years ago

We had a problem with a cfengine command not doing what was expected due to a utf-8 space in place of a space.
We also add a problem with a third party scripts (python I believe?) that didn't parsed the content as expected due to them (it was breaking regex).

The bigger problem is that it breaks any regex apply on these file when done by human looking for space. It's surprising and deceving.

Actions
Copy link
 #14

Updated by Jonathan CLARKE over 7 years ago

  • Severity set to Minor - inconvenience | misleading | easy workaround
  • User visibility set to Infrequent - complex configurations | third party integrations
Actions
Copy link
 #15

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.19 to 3.1.20
  • Priority set to 0
Actions
Copy link
 #16

Updated by Jonathan CLARKE over 7 years ago

  • Status changed from Discussion to New
Actions
Copy link
 #17

Updated by Jonathan CLARKE over 7 years ago

  • Assignee deleted (François ARMAND)
Actions
Copy link
 #18

Updated by Jonathan CLARKE over 7 years ago

  • Status changed from New to In progress
  • Assignee set to Jonathan CLARKE
Actions
Copy link
 #19

Updated by Jonathan CLARKE over 7 years ago

I will add a test to 'make test' to detect any such characters, at the same time as removing all existing ones. This should enable easy detection if they were to come back, or a merge were to reintroduce them.

Actions
Copy link
 #20

Updated by Jonathan CLARKE over 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/1139
Actions
Copy link
 #21

Updated by Jonathan CLARKE over 7 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #22

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.1.20, 4.0.5 and 4.1.2 which were released today.

Actions
Copy link

Also available in: Atom PDF