Project

General

Profile

Actions
Copy link

Bug #7622

closed

Technique files contains UTF-8 chars (especially spaces)

Bug #7622: Technique files contains UTF-8 chars (especially spaces)

Added by François ARMAND almost 10 years ago. Updated over 8 years ago.

Status:
Released
Priority:
4
Assignee:
Benoît PECCATTE
Category:
Techniques
Target version:
3.1.20
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

There is several techniques files containing UTF-8 chars, especially an UTF-8 space.

AFAIK, these chars are only in comments, but I only looked in system techniques.

The problem with a change to remove them will be in merge where it will be hard to know what is the correct space to get.

For information, the joined file is a list of such chars in system techniques.

Files

utf8_spaces.patch (10.4 KB) utf8_spaces.patch François ARMAND, 2015-12-16 14:51

Updated by Jonathan CLARKE almost 10 years ago Actions
Copy link
 #1

  • Assignee set to François ARMAND

I understand the observation, but I don't understand the problem - you have filed this as a bug, so could you please explain the negative impact or perceived risk?

Updated by Benoît PECCATTE over 9 years ago Actions
Copy link
 #2

  • Target version set to 2.11.21

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #3

  • Target version changed from 2.11.21 to 2.11.22

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #4

  • Target version changed from 2.11.22 to 2.11.23

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #5

  • Target version changed from 2.11.23 to 2.11.24

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #6

  • Target version changed from 2.11.24 to 308

Updated by Vincent MEMBRÉ about 9 years ago Actions
Copy link
 #7

  • Target version changed from 308 to 3.1.14

Updated by Vincent MEMBRÉ about 9 years ago Actions
Copy link
 #8

  • Target version changed from 3.1.14 to 3.1.15

Updated by Vincent MEMBRÉ about 9 years ago Actions
Copy link
 #9

  • Target version changed from 3.1.15 to 3.1.16

Updated by Vincent MEMBRÉ about 9 years ago Actions
Copy link
 #10

  • Target version changed from 3.1.16 to 3.1.17

Updated by Vincent MEMBRÉ about 9 years ago Actions
Copy link
 #11

  • Target version changed from 3.1.17 to 3.1.18

Updated by Vincent MEMBRÉ almost 9 years ago Actions
Copy link
 #12

  • Target version changed from 3.1.18 to 3.1.19

Updated by François ARMAND almost 9 years ago Actions
Copy link
 #13

We had a problem with a cfengine command not doing what was expected due to a utf-8 space in place of a space.
We also add a problem with a third party scripts (python I believe?) that didn't parsed the content as expected due to them (it was breaking regex).

The bigger problem is that it breaks any regex apply on these file when done by human looking for space. It's surprising and deceving.

Updated by Jonathan CLARKE over 8 years ago Actions
Copy link
 #14

  • Severity set to Minor - inconvenience | misleading | easy workaround
  • User visibility set to Infrequent - complex configurations | third party integrations

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #15

  • Target version changed from 3.1.19 to 3.1.20
  • Priority set to 0

Updated by Jonathan CLARKE over 8 years ago Actions
Copy link
 #16

  • Status changed from Discussion to New

Updated by Jonathan CLARKE over 8 years ago Actions
Copy link
 #17

  • Assignee deleted (François ARMAND)

Updated by Jonathan CLARKE over 8 years ago Actions
Copy link
 #18

  • Status changed from New to In progress
  • Assignee set to Jonathan CLARKE

Updated by Jonathan CLARKE over 8 years ago Actions
Copy link
 #19

I will add a test to 'make test' to detect any such characters, at the same time as removing all existing ones. This should enable easy detection if they were to come back, or a merge were to reintroduce them.

Updated by Jonathan CLARKE over 8 years ago Actions
Copy link
 #20

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/1139

Updated by Jonathan CLARKE over 8 years ago Actions
Copy link
 #21

  • Status changed from Pending technical review to Pending release

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #22

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.1.20, 4.0.5 and 4.1.2 which were released today.

Actions
Copy link

Also available in: PDF Atom