Bug #8837: Makke uuidgen a single point of uuid generation - Rudder - Issue Tracker

Custom queries

8.1 beta
Bugs triage
CS - by priority
CS - to review
My TR
Need technical review
Open bugs (all)
Open bugs (UI - UX)
Open UX defects (all)
Opened by users

Actions

Copy link

Bug #8837

closed

Makke uuidgen a single point of uuid generation

Added by Alexis Mousset over 8 years ago. Updated about 8 years ago.

Status:

Released

Priority:

N/A

Assignee:

Alexis Mousset

Category:

Packaging

Target version:

4.0.0~rc1

Pull Request:

https://github.com/Normation/rudder-p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

/opt/rudder/bin/uuidgen: line 9: makeuuid: command not found

The uuidgen binary in /opt/rudder/bin should not ne balled uuigden since it does not have the same API as the read uuidgen binary.

Let's call it rudder-uuidgen.

Then it should be the only way to generate uuid, called by all other places that need. Thus it could contain all the smart thing we want to rudder the right uuid generation method depending on the situation.

Subtasks 1 (0 open — 1 closed)

Architecture #8987: call rudder-uuidgen in rudder agent check

Released

Alexis Mousset

2016-09-09

Actions

Related issues 1 (0 open — 1 closed)

Related to Rudder - Bug #9040: uuidgen should not be source packaged anymore

Released

Alexis Mousset

2016-09-14

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Jonathan CLARKE about 8 years ago

Target version set to 4.0.0~rc2

The file /opt/rudder/bin/uuidgen should not be installed on SLES. It should only be installed on AIX. This comes from the use of a single Makefile in master:
https://github.com/Normation/rudder-packages/blob/master/rudder-agent/SOURCES/Makefile#L189

Please also add a comment in the uuidgen file to explain this should only be used on AIX. And actually add a check, and if the OS has a uuidgen command use it, and only use our workaround if not.

Actions

Copy link

Updated by Alexis Mousset about 8 years ago

Subject changed from Missing makeuuid on sles 12 to Missing makeuuid on RPM systems

Actions

Copy link

Updated by Alexis Mousset about 8 years ago

Status changed from New to In progress

Actions

Copy link

Updated by Alexis Mousset about 8 years ago

Status changed from In progress to Pending technical review
Assignee changed from Alexis Mousset to Jonathan CLARKE
Pull Request set to https://github.com/Normation/rudder-packages/pull/1024

PR https://github.com/Normation/rudder-packages/pull/1024

Actions

Copy link

Updated by Benoît PECCATTE about 8 years ago

Description updated (diff)

The uuidgen binary in /opt/rudder/bin should not ne balled uuigden since it does not have the same API as the read uuidgen binary.

Let's call it rudder-uuidgen.

Then it should be the only way to generate uuid, called by all other places that need it.

Actions

Copy link

Updated by Benoît PECCATTE about 8 years ago

Subject changed from Missing makeuuid on RPM systems to Makke uuidgen a single point of uuid generation

Actions

Copy link

Updated by Benoît PECCATTE about 8 years ago

Status changed from Pending technical review to In progress
Assignee changed from Jonathan CLARKE to Benoît PECCATTE

Actions

Copy link

Updated by Benoît PECCATTE about 8 years ago

Status changed from In progress to Pending technical review
Assignee changed from Benoît PECCATTE to Alexis Mousset
Pull Request changed from https://github.com/Normation/rudder-packages/pull/1024 to https://github.com/Normation/rudder-packages/pull/1039

PR https://github.com/Normation/rudder-packages/pull/1039

Actions

Copy link