Project

General

Profile

Actions
Copy link

User story #8889

closed

Update JGit to version > 4.0 to support pre-commit hook on configuration repository

Added by François ARMAND about 8 years ago. Updated about 8 years ago.

Status:
Released
Priority:
3
Assignee:
Jonathan CLARKE
Category:
System integration
Target version:
3.1.13
Pull Request:
https://github.com/Normation/rudder-p...
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

For integration needs, it would be handy to have access to git hooks on configuration-repository.

Unfortunatly, JGit doesn't supports them until recently, and even now (jgit 4.2), it supports only three (http://zaunerc.blogspot.fr/2015/11/git-hooks-currently-supported-by-jgit.html): pre-commit, prepare-commit-msg, pre-push

These are not the most usefull for Rudder, but at least they exists.

Exceptionnaly, this feature will be introduced in LTS branch (3.1), because it is low risk, does not impact existing behaviour, and have nothing to do with node config.

Subtasks 3 (0 open — 3 closed)

User story #8890: Update name of release method (cf-clerk)ReleasedJonathan CLARKE2016-08-25Actions
User story #8891: Update dependency name (rudder 3.2)ReleasedJonathan CLARKE2016-08-25Actions
User story #8892: Update dependency name (rudder)ReleasedJonathan CLARKE2016-08-25Actions
Actions
Copy link
 #1

Updated by François ARMAND about 8 years ago

  • Category set to System integration
  • Priority changed from N/A to 3
  • Target version set to 3.1.13
Actions
Copy link
 #2

Updated by François ARMAND about 8 years ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions
Copy link
 #3

Updated by François ARMAND about 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/rudder-parent-pom/pull/27
Actions
Copy link
 #4

Updated by François ARMAND about 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 50 to 100
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ about 8 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.1.13 and 3.2.6 which were released today.

Actions
Copy link
 #6

Updated by Florian Heigl about 8 years ago

This is also a feature users might like, is it intended to be used outside of your CI?

Actions
Copy link
 #7

Updated by Jonathan CLARKE about 8 years ago

Florian Heigl wrote:

This is also a feature users might like, is it intended to be used outside of your CI?

It is not intended to be used in our CI at all :)

The JGit module is a Java library used by the Rudder Scala application to manage the git repository in /var/rudder/configuration-repository. The pre-commit hook referred to is that one - on any and all Rudder installations.

So yes, it is a feature for users :-)

Actions
Copy link

Also available in: Atom PDF