Bug #8972: Check/Verify package generic methods are actually installing packages - Rudder - Issue Tracker

Actions

Copy link

Bug #8972

closed

Check/Verify package generic methods are actually installing packages

Added by Alexis Mousset over 8 years ago. Updated over 2 years ago.

Status:

Released

Priority:

N/A

Assignee:

Nicolas CHARLES

Category:

Generic methods

Target version:

ncf-0.x

Pull Request:

https://github.com/Normation/ncf/pull...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

The warn class that is supposed to prevent the agent from modifying the system is private and not available in the package promise, where it is supposed to be used (in the action body).

Furthermore reporting is misleading because repaired are displayed as error, so the first run may appear correct:

package_check_installed:

      "failed" 
        usebundle  => _classes_failure("${old_class_prefix}"),
        ifvarclass => "${called_class_prefix}_repaired";

Actions

Copy link

Updated by Alexis Mousset over 8 years ago

Subject changed from Check/Verify package generic methods are actually installing packages to Check/Verify package generic methods are actually installing/removing packages

Actions

Copy link

Updated by François ARMAND over 8 years ago

It used to work in CFEngine 3.5 (and 3.6 ?), because classes defined in the bundle are viewable in the body. We must check if that changed recently.

Actions

Copy link

Updated by Alexis Mousset over 8 years ago

Subject changed from Check/Verify package generic methods are actually installing/removing packages to Check/Verify package generic methods are actually installing packages
Assignee set to Alexis Mousset

Reproduced on 3.1.13.

Actions

Copy link

Updated by Alexis Mousset over 8 years ago

Reproduced with a simpler test case, but could not find an item in changelogs for this.

body common control {

    bundlesequence => { "test" };

}

bundle agent test {

classes:

#"plop" expression => "any", scope => "namespace";
"plop" expression => "any";

files:

          "/tmp/passwd" 
            perms => system;
}

    body perms system
    {
plop::
      mode => "644";
      owners => { "root" };
      groups => { "root" };
    }

Actions

Copy link

Updated by Alexis Mousset over 8 years ago

Status changed from New to In progress

Actions

Copy link

Updated by Alexis Mousset over 8 years ago

Status changed from In progress to Pending technical review
Assignee changed from Alexis Mousset to Nicolas CHARLES
Pull Request set to https://github.com/Normation/ncf/pull/442

PR https://github.com/Normation/ncf/pull/442

Actions

Copy link

Updated by Nicolas CHARLES over 8 years ago

I checked the promises, and:

it works as expected in CFEngine 3.5.3
it doesn't do anything in CFEngine 3.6.0
so it's been failing since Rudder 2.11 - and it's something that changed in CFEngine 3.6

Actions

Copy link