Project

General

Profile

Actions

Bug #8972

closed

Check/Verify package generic methods are actually installing packages

Added by Alexis Mousset about 6 years ago. Updated 4 months ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

The warn class that is supposed to prevent the agent from modifying the system is private and not available in the package promise, where it is supposed to be used (in the action body).

Furthermore reporting is misleading because repaired are displayed as error, so the first run may appear correct:

package_check_installed:

      "failed" 
        usebundle  => _classes_failure("${old_class_prefix}"),
        ifvarclass => "${called_class_prefix}_repaired";

Actions #1

Updated by Alexis Mousset about 6 years ago

  • Subject changed from Check/Verify package generic methods are actually installing packages to Check/Verify package generic methods are actually installing/removing packages
Actions #2

Updated by François ARMAND about 6 years ago

It used to work in CFEngine 3.5 (and 3.6 ?), because classes defined in the bundle are viewable in the body. We must check if that changed recently.

Actions #3

Updated by Alexis Mousset about 6 years ago

  • Subject changed from Check/Verify package generic methods are actually installing/removing packages to Check/Verify package generic methods are actually installing packages
  • Assignee set to Alexis Mousset

Reproduced on 3.1.13.

Actions #4

Updated by Alexis Mousset about 6 years ago

Reproduced with a simpler test case, but could not find an item in changelogs for this.

body common control {

    bundlesequence => { "test" };

}

bundle agent test {

classes:

#"plop" expression => "any", scope => "namespace";
"plop" expression => "any";

files:

          "/tmp/passwd" 
            perms => system;
}

    body perms system
    {
plop::
      mode => "644";
      owners => { "root" };
      groups => { "root" };
    }

Actions #5

Updated by Alexis Mousset about 6 years ago

  • Status changed from New to In progress
Actions #6

Updated by Alexis Mousset about 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis Mousset to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/ncf/pull/442
Actions #7

Updated by Nicolas CHARLES about 6 years ago

I checked the promises, and:
  • it works as expected in CFEngine 3.5.3
  • it doesn't do anything in CFEngine 3.6.0
    so it's been failing since Rudder 2.11 - and it's something that changed in CFEngine 3.6
Actions #8

Updated by Alexis Mousset about 6 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:55876a92615d66170a84e821d589c7a918551ae5.

Actions #9

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in ncf version that comes with Rudder 3.1.15/14 and 3.2.8/7 which were released today.

Actions #10

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #11

Updated by Alexis Mousset 4 months ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods to Generic methods
Actions

Also available in: Atom PDF